mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Feng Wu <feng.wu@intel.com>
To: pbonzini@redhat.com, alex.williamson@redhat.com, joro@8bytes.org,
	mtosatti@redhat.com
Cc: eric.auger@linaro.org, kvm@vger.kernel.org,
	iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org,
	Feng Wu <feng.wu@intel.com>
Subject: [PATCH v7 14/17] KVM: Update Posted-Interrupts Descriptor when vCPU is preempted
Date: Tue, 25 Aug 2015 16:50:17 +0800	[thread overview]
Message-ID: <1440492620-15934-15-git-send-email-feng.wu@intel.com> (raw)
In-Reply-To: <1440492620-15934-1-git-send-email-feng.wu@intel.com>

This patch updates the Posted-Interrupts Descriptor when vCPU
is preempted.

sched out:
- Set 'SN' to suppress furture non-urgent interrupts posted for
the vCPU.

sched in:
- Clear 'SN'
- Change NDST if vCPU is scheduled to a different CPU
- Set 'NV' to POSTED_INTR_VECTOR

Signed-off-by: Feng Wu <feng.wu@intel.com>
---
 arch/x86/kvm/vmx.c | 51 +++++++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 51 insertions(+)

diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c
index 234f720..9c87064 100644
--- a/arch/x86/kvm/vmx.c
+++ b/arch/x86/kvm/vmx.c
@@ -45,6 +45,7 @@
 #include <asm/debugreg.h>
 #include <asm/kexec.h>
 #include <asm/apic.h>
+#include <asm/irq_remapping.h>
 
 #include "trace.h"
 #include "pmu.h"
@@ -2001,10 +2002,60 @@ static void vmx_vcpu_load(struct kvm_vcpu *vcpu, int cpu)
 		vmcs_writel(HOST_IA32_SYSENTER_ESP, sysenter_esp); /* 22.2.3 */
 		vmx->loaded_vmcs->cpu = cpu;
 	}
+
+	if (irq_remapping_cap(IRQ_POSTING_CAP)) {
+		struct pi_desc *pi_desc = vcpu_to_pi_desc(vcpu);
+		struct pi_desc old, new;
+		unsigned int dest;
+
+		do {
+			old.control = new.control = pi_desc->control;
+
+			/*
+			 * If 'nv' field is POSTED_INTR_WAKEUP_VECTOR, there
+			 * are two possible cases:
+			 * 1. After running 'pi_pre_block', context switch
+			 *    happened. For this case, 'sn' was set in
+			 *    vmx_vcpu_put(), so we need to clear it here.
+			 * 2. After running 'pi_pre_block', we were blocked,
+			 *    and woken up by some other guy. For this case,
+			 *    we don't need to do anything, 'pi_post_block'
+			 *    will do everything for us. However, we cannot
+			 *    check whether it is case #1 or case #2 here
+			 *    (maybe, not needed), so we also clear sn here,
+			 *    I think it is not a big deal.
+			 */
+			if (pi_desc->nv != POSTED_INTR_WAKEUP_VECTOR) {
+				if (vcpu->cpu != cpu) {
+					dest = cpu_physical_id(cpu);
+
+					if (x2apic_enabled())
+						new.ndst = dest;
+					else
+						new.ndst = (dest << 8) & 0xFF00;
+				}
+
+				/* set 'NV' to 'notification vector' */
+				new.nv = POSTED_INTR_VECTOR;
+			}
+
+			/* Allow posting non-urgent interrupts */
+			new.sn = 0;
+		} while (cmpxchg(&pi_desc->control, old.control,
+				new.control) != old.control);
+	}
 }
 
 static void vmx_vcpu_put(struct kvm_vcpu *vcpu)
 {
+	if (irq_remapping_cap(IRQ_POSTING_CAP)) {
+		struct pi_desc *pi_desc = vcpu_to_pi_desc(vcpu);
+
+		/* Set SN when the vCPU is preempted */
+		if (vcpu->preempted)
+			pi_set_sn(pi_desc);
+	}
+
 	__vmx_load_host_state(to_vmx(vcpu));
 	if (!vmm_exclusive) {
 		__loaded_vmcs_clear(to_vmx(vcpu)->loaded_vmcs);
-- 
2.1.0


  parent reply	other threads:[~2015-08-25  9:18 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-25  8:50 [PATCH v7 00/17] Add VT-d Posted-Interrupts support Feng Wu
2015-08-25  8:50 ` [PATCH v7 01/17] KVM: Extend struct pi_desc for VT-d Posted-Interrupts Feng Wu
2015-08-25  8:50 ` [PATCH v7 02/17] KVM: Add some helper functions for Posted-Interrupts Feng Wu
2015-09-11 10:16   ` Paolo Bonzini
2015-08-25  8:50 ` [PATCH v7 03/17] KVM: Define a new interface kvm_intr_is_single_vcpu() Feng Wu
2015-09-11 10:20   ` Paolo Bonzini
2015-08-25  8:50 ` [PATCH v7 04/17] KVM: Get Posted-Interrupts descriptor address from 'struct kvm_vcpu' Feng Wu
2015-09-11 10:50   ` Paolo Bonzini
2015-08-25  8:50 ` [PATCH v7 05/17] KVM: Add interfaces to control PI outside vmx Feng Wu
2015-08-25  8:50 ` [PATCH v7 06/17] KVM: Make struct kvm_irq_routing_table accessible Feng Wu
2015-09-11 10:50   ` Paolo Bonzini
2015-08-25  8:50 ` [PATCH v7 07/17] KVM: make kvm_set_msi_irq() public Feng Wu
2015-09-11 10:53   ` Paolo Bonzini
2015-08-25  8:50 ` [PATCH v7 08/17] vfio: Select IRQ_BYPASS_MANAGER for vfio PCI devices Feng Wu
2015-09-11 10:54   ` Paolo Bonzini
2015-08-25  8:50 ` [PATCH v7 09/17] vfio: Register/unregister irq_bypass_producer Feng Wu
2015-08-25  8:50 ` [PATCH v7 10/17] KVM: x86: Update IRTE for posted-interrupts Feng Wu
2015-08-25 19:57   ` Alex Williamson
2015-08-26  0:36     ` Wu, Feng
2015-09-11 10:29   ` Paolo Bonzini
2015-08-25  8:50 ` [PATCH v7 11/17] KVM: Define two weak arch callbacks for irq bypass manager Feng Wu
2015-09-11 10:41   ` Paolo Bonzini
2015-08-25  8:50 ` [PATCH v7 12/17] KVM: Implement IRQ bypass consumer callbacks for x86 Feng Wu
2015-09-11 10:31   ` Paolo Bonzini
2015-08-25  8:50 ` [PATCH v7 13/17] KVM: Add an arch specific hooks in 'struct kvm_kernel_irqfd' Feng Wu
2015-09-11 10:39   ` Paolo Bonzini
2015-08-25  8:50 ` Feng Wu [this message]
2015-09-11 10:56   ` [PATCH v7 14/17] KVM: Update Posted-Interrupts Descriptor when vCPU is preempted Paolo Bonzini
2015-08-25  8:50 ` [PATCH v7 15/17] KVM: Update Posted-Interrupts Descriptor when vCPU is blocked Feng Wu
2015-09-11 11:21   ` Paolo Bonzini
2015-09-14  7:57     ` Wu, Feng
2015-08-25  8:50 ` [PATCH v7 16/17] KVM: Warn if 'SN' is set during posting interrupts by software Feng Wu
2015-09-11 10:59   ` Paolo Bonzini
2015-08-25  8:50 ` [PATCH v7 17/17] iommu/vt-d: Add a command line parameter for VT-d posted-interrupts Feng Wu
2015-09-11 11:05   ` Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1440492620-15934-15-git-send-email-feng.wu@intel.com \
    --to=feng.wu@intel.com \
    --cc=alex.williamson@redhat.com \
    --cc=eric.auger@linaro.org \
    --cc=iommu@lists.linux-foundation.org \
    --cc=joro@8bytes.org \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mtosatti@redhat.com \
    --cc=pbonzini@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®