From: Alexander Shishkin <alexander.shishkin@linux.intel.com>
To: Peter Zijlstra <a.p.zijlstra@chello.nl>, Ingo Molnar <mingo@redhat.com>
Cc: linux-kernel@vger.kernel.org, x86@kernel.org, hpa@zytor.com,
Arnaldo Carvalho de Melo <acme@infradead.org>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>
Subject: [PATCH v1 0/2] perf/x86/intel: Work around BTS leaking kernel addresses
Date: Mon, 31 Aug 2015 17:09:26 +0300 [thread overview]
Message-ID: <1441030168-6853-1-git-send-email-alexander.shishkin@linux.intel.com> (raw)
Hi Peter and Ingo,
This is a respin to address Ingo's comments: I replaced the awkward
address comparison against PAGE_OFFSET with a kernel_ip() in the first
patch and amended the wording in the second. The original story
follows.
Due to imprecise IP sampling, BTS may (and often does) leak kernel
addresses when kernel tracing is not even enabled, which results in
mostly syscall entry points and page_fault handler addresses being
exposed. This might be a security concern for the address
randomization, and it also makes life harder for gdb that makes use of
bts samples.
This patchset works around the old (DS) driver and disables the new
(intel_bts) for the unprivileged users on systems where perf paranoia
level prohibits kernel tracing.
Not sure if these should be treated as bugfixes.
Alexander Shishkin (2):
perf/x86/intel/ds: Work around BTS leaking kernel addresses
perf/x86/intel/bts: Disallow use by unprivileged users on paranoid
systems
arch/x86/kernel/cpu/perf_event_intel_bts.c | 13 ++++++++++
arch/x86/kernel/cpu/perf_event_intel_ds.c | 40 +++++++++++++++++++++++++-----
2 files changed, 47 insertions(+), 6 deletions(-)
--
2.5.0
next reply other threads:[~2015-08-31 14:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-31 14:09 Alexander Shishkin [this message]
2015-08-31 14:09 ` [PATCH v1 1/2] perf/x86/intel/ds: " Alexander Shishkin
2015-09-13 11:08 ` [tip:perf/core] " tip-bot for Alexander Shishkin
2015-08-31 14:09 ` [PATCH v1 2/2] perf/x86/intel/bts: Disallow use by unprivileged users on paranoid systems Alexander Shishkin
2015-09-13 11:08 ` [tip:perf/core] " tip-bot for Alexander Shishkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1441030168-6853-1-git-send-email-alexander.shishkin@linux.intel.com \
--to=alexander.shishkin@linux.intel.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@infradead.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®