From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753515AbbHaQBj (ORCPT <rfc822;w@1wt.eu>);
	Mon, 31 Aug 2015 12:01:39 -0400
Received: from metis.ext.pengutronix.de ([92.198.50.35]:42055 "EHLO
	metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752792AbbHaQBi (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 31 Aug 2015 12:01:38 -0400
Message-ID: <1441036886.3234.50.camel@pengutronix.de>
Subject: Re: [PATCH] reset: Add (devm_)reset_control_get stub functions
From: Philipp Zabel <p.zabel@pengutronix.de>
To: Axel Lin <axel.lin@ingics.com>
Cc: Mark Brown <broonie@kernel.org>, Takashi Iwai <tiwai@suse.com>,
        Arnaud Pouliquen <arnaud.pouliquen@st.com>,
        Liam Girdwood <lgirdwood@gmail.com>, alsa-devel@alsa-project.org,
        linux-kernel@vger.kernel.org
Date: Mon, 31 Aug 2015 18:01:26 +0200
In-Reply-To: <1441012943.22251.1.camel@ingics.com>
References: <1441012943.22251.1.camel@ingics.com>
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.12.9-1+b1 
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
X-SA-Exim-Connect-IP: 2001:67c:670:100:96de:80ff:fec2:9969
X-SA-Exim-Mail-From: p.zabel@pengutronix.de
X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false
X-PTX-Original-Recipient: linux-kernel@vger.kernel.org
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Axel,

thank you for the patch.

Am Montag, den 31.08.2015, 17:22 +0800 schrieb Axel Lin:
> So the drivers can be compiled with CONFIG_RESET_CONTROLLER disabled.
> 
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
> ---
>  include/linux/reset.h | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
> 
> diff --git a/include/linux/reset.h b/include/linux/reset.h
> index da5602b..cd42c1b 100644
> --- a/include/linux/reset.h
> +++ b/include/linux/reset.h
> @@ -74,6 +74,18 @@ static inline int device_reset_optional(struct device *dev)
>  	return -ENOSYS;
>  }
>  
> +static inline struct reset_control *reset_control_get(
> +					struct device *dev, const char *id)
> +{
> +	return ERR_PTR(-ENOSYS);
> +}
> +
> +static inline struct reset_control *devm_reset_control_get(
> +					struct device *dev, const char *id)
> +{
> +	return ERR_PTR(-ENOSYS);
> +}
> +

Could you add a WARN_ON(1) to both, make them __must_check, and return
something other than -ENOSYS. For example the gpio stubs return -EINVAL.

regards
Philipp