From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753659AbcIBWoX (ORCPT ); Fri, 2 Sep 2016 18:44:23 -0400 Received: from mout.kundenserver.de ([217.72.192.73]:57913 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752376AbcIBWoS (ORCPT ); Fri, 2 Sep 2016 18:44:18 -0400 From: Arnd Bergmann To: Laura Abbott Cc: Jonathan Corbet , Randy Dunlap , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] doc: ioctl: Add some clarifications to botching-up-ioctls Date: Sat, 03 Sep 2016 00:44:02 +0200 Message-ID: <14410979.OgeTP9zliP@wuerfel> User-Agent: KMail/5.1.3 (Linux/4.4.0-34-generic; KDE/5.18.0; x86_64; ; ) In-Reply-To: <1472856144-4659-1-git-send-email-labbott@redhat.com> References: <1472856144-4659-1-git-send-email-labbott@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:70hJHAqwsjF3pLT9ynj/IQUbypvgjAvuyRbzsesPMPxsydHd+5l eLImKUzzUfFOXs9BFhREy7VNZjmBuh1MfPAMCg+bGYTsQdmQDAHDuuhUlTtqLl1efngG/cc EEL9j986nMLgT3e7ngTQFryt7Du/c3HLKEf9dSNiZgDa/S3JrUcxbAZ9ZhhZiJhGNvY1E6G lSN1kPeWeu5gN3wTXR3OA== X-UI-Out-Filterresults: notjunk:1;V01:K0:bOT7a6T8Xd0=:hyOAdhsehpWEnlwQ2zgrR8 1TnbDM1zDHeUes7n7ErulBPI8bQ0afQkLTygqEqC/MW0yni1a2a9+iHlRVLIy1V6EyRmTHBMC mm1g88dHY1W3buddit1d1TLnoX1RhuDxAwYHOu9n7Xnj0PUIDErS9h6f7BtIgRFNt0JdXSOV7 wFeWqIFkCwTnGUF7NJDCB7e/bHfREU1fHpM5noeJ9PWDUq9LMOWZnDN3ZSQhOGwsoiTrJDCi0 9ch1gmv4QGzfQm9xx0YkD8Wz18z9Rb3GgLDMgpNb/DsHeQ9/0lL0Fs+JBBaskZoR0jPoG5WW8 8MOFcyk1Ebqtjm100gg/izaUqqwQkAnQDhP0386qbegqQRAS+QmaCJ7Ncl0C/PPofXR3hRiDR VJsyPfaP29PWlPjVAUFUWrXUow2CZJxZpTuOf6KOFCDpQ1DRlDU0lQxjMfo7KKRqy3XI9kD45 EL5Whh0fWZgT7mfLXM9N8slXe6pOd7WcYx9Lir3x0yWSMb+gTio79YhVEYneMMD5wy9d6XByv nkw26yI0hOiyE8KD/meAi548Imuda8SwCpofNAvJatdVhxpTg/HM8J/9QHCVFilt7yafrJWGt i/5DX12UsvYC5XFtp9tSsdW7k1IhUeAljuJgL2Pcl/7CU7QTS4axf15BE3oaUfXdi+o417uCo cqU6b0Nx0oWy1qQUKHx/6QiQyFXMowMwB+OU5LLs1HHypak6yQ1Xb4mKdlNV3kH3PbwhEBv53 R4u9GZpWjL1dqbpN Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Friday, September 2, 2016 3:42:24 PM CEST Laura Abbott wrote: > - The guide currently says to pad the structure to a multiple of > 64-bits. This is not necessary in cases where the structure contains > no 64-bit types. Clarify this concept to avoid unnecessary padding. > - When using __u64 to hold user pointers, blindly trying to do a cast to > a void __user * may generate a warning on 32-bit systems about a cast > from an integer to a pointer of different size. There is a macro to > deal with this which hides an ugly double cast. Add a reference to > this macro. > > Signed-off-by: Laura Abbott > Looks good to me, Acked-by: Arnd Bergmann