From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755503AbbIALqQ (ORCPT ); Tue, 1 Sep 2015 07:46:16 -0400 Received: from mailgw01.mediatek.com ([218.249.47.110]:50483 "EHLO mailgw01.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1752648AbbIALqN (ORCPT ); Tue, 1 Sep 2015 07:46:13 -0400 X-Listener-Flag: 11101 Message-ID: <1441107965.26285.6.camel@mhfsdcap03> Subject: Re: [PATCH v6 2/5] dt-bindings: Add a binding for Mediatek xHCI host controller From: chunfeng yun To: Sergei Shtylyov CC: Mathias Nyman , Rob Herring , Mark Rutland , "Matthias Brugger" , Felipe Balbi , "Sascha Hauer" , , , , "Roger Quadros" , , , John Crispin , Daniel Kurtz , Kishon Vijay Abraham I Date: Tue, 1 Sep 2015 19:46:05 +0800 In-Reply-To: <55D877DD.3010400@cogentembedded.com> References: <1440207911-17666-1-git-send-email-chunfeng.yun@mediatek.com> <1440207911-17666-3-git-send-email-chunfeng.yun@mediatek.com> <55D877DD.3010400@cogentembedded.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.3-0ubuntu6 Content-Transfer-Encoding: 7bit MIME-Version: 1.0 X-MTK: N Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org hi, On Sat, 2015-08-22 at 16:23 +0300, Sergei Shtylyov wrote: > Hello. > > On 8/22/2015 4:45 AM, Chunfeng Yun wrote: > > > add a DT binding documentation of xHCI host controller for the > > MT8173 SoC from Mediatek. > > > Signed-off-by: Chunfeng Yun > > --- > > .../devicetree/bindings/usb/mt8173-xhci.txt | 52 ++++++++++++++++++++++ > > 1 file changed, 52 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/usb/mt8173-xhci.txt > > > > diff --git a/Documentation/devicetree/bindings/usb/mt8173-xhci.txt b/Documentation/devicetree/bindings/usb/mt8173-xhci.txt > > new file mode 100644 > > index 0000000..8e6e463 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/usb/mt8173-xhci.txt > > @@ -0,0 +1,52 @@ > > +mt65XX xHCI > > The file is called mt8173-xhci.txt. Are you sure MT65xx should be here? > I will revise it later. > > + > > +The device node for Mediatek SOC usb3.0 host controller > > + > > +Required properties: > > + - compatible : should contain "mediatek,mt8173-xhci" > > + - reg : specifies physical base address and size of the registers, > > + the first one for MAC, the second for IPPC > > + - interrupts : interrupt used by the controller > > + - power-domains : a phandle to USB power domain node to control usb's > > USB's -- be consistent, please. > > > + mtcmos > > + - vusb33-supply : regulator of usb avdd3.3v > > + > > + - clocks : a list of phandle + clock-specifier pairs, one for each > > + entry in clock-names > > + - clock-names : must contain > > + "sys_ck": for clock of xHCI MAC > > + "wakeup_deb_p0": for usb wakeup debounce clock of port0 > > + "wakeup_deb_p0": for usb wakeup debounce clock of port1 > > USB. > > > + > > + - phys : a list of phandle + phy specifier pairs > > + - usb3-lpm-capable : supports USB3 LPM > > + - mediatek,syscon-wakeup : phandle to syscon used to access usb wakeup > > + control register > > + - mediatek,wakeup-src : 1: ip sleep wakeup mode; 2: line state wakeup > > + mode; others means don't enable wakeup source of usb > > "Others mean" and "USB". > I will replace all 'usb' by "USB" Thanks a lot, and sorry for later reply. > [...] > > MBR, Sergei >