From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752501AbbIAUhZ (ORCPT ); Tue, 1 Sep 2015 16:37:25 -0400 Received: from smtprelay0098.hostedemail.com ([216.40.44.98]:55731 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752023AbbIAUhX (ORCPT ); Tue, 1 Sep 2015 16:37:23 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::,RULES_HIT:41:355:379:541:599:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1539:1593:1594:1711:1714:1730:1747:1777:1792:2393:2559:2562:2828:2892:2899:3138:3139:3140:3141:3142:3351:3622:3865:3866:3867:3870:3871:3874:4321:5007:6119:6261:7903:10004:10400:10848:11026:11232:11658:11914:12043:12296:12517:12519:12663:12740:13069:13095:13255:13311:13357:21080,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0 X-HE-Tag: river76_7a36d918f0116 X-Filterd-Recvd-Size: 1725 Message-ID: <1441139838.12163.5.camel@perches.com> Subject: Re: [PATCH 2/2] mmc: sdhci-pxav3: Print ret value on error from sdhci_add_host() fn From: Joe Perches To: Vaibhav Hiremath Cc: linux-mmc@vger.kernel.org, ulf.hansson@linaro.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Date: Tue, 01 Sep 2015 13:37:18 -0700 In-Reply-To: <1441135454-6902-3-git-send-email-vaibhav.hiremath@linaro.org> References: <1441135454-6902-1-git-send-email-vaibhav.hiremath@linaro.org> <1441135454-6902-3-git-send-email-vaibhav.hiremath@linaro.org> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.12.11-0ubuntu3 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2015-09-02 at 00:54 +0530, Vaibhav Hiremath wrote: > Return value would give clear information about the actual root-cause > of the failure. I'm not sure why that is as nearly every error path in sdhci_add_host emits a message. > diff --git a/drivers/mmc/host/sdhci-pxav3.c b/drivers/mmc/host/sdhci-pxav3.c [] > @@ -455,7 +455,7 @@ static int sdhci_pxav3_probe(struct platform_device *pdev) > > ret = sdhci_add_host(host); > if (ret) { > - dev_err(&pdev->dev, "failed to add host\n"); > + dev_err(&pdev->dev, "failed to add host ret - %d\n", ret); > goto err_add_host; > } > If this is really desirable, there are many other callers of sdhci_add_host with error messages just like this one.