From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753838AbbIAWn2 (ORCPT ); Tue, 1 Sep 2015 18:43:28 -0400 Received: from mga14.intel.com ([192.55.52.115]:12549 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753797AbbIAWnZ (ORCPT ); Tue, 1 Sep 2015 18:43:25 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.17,451,1437462000"; d="scan'208";a="795842126" Subject: Re: [Open-FCoE] [PATCH] scsi: fcoe: Convert use of __constant_htons to htons From: Vasu Dev To: Vaishali Thakkar Cc: Vasu Dev , fcoe-devel@open-fcoe.org, "James E.J. Bottomley" , linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org In-Reply-To: <20150819054844.GA21960@localhost> References: <20150819054844.GA21960@localhost> Content-Type: text/plain; charset="UTF-8" Date: Tue, 01 Sep 2015 15:43:24 -0700 Message-ID: <1441147404.19451.52.camel@lin-nd1-054.jf.intel.com> Mime-Version: 1.0 X-Mailer: Evolution 2.32.3 (2.32.3-1.fc14) Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2015-08-19 at 11:18 +0530, Vaishali Thakkar wrote: > In little endian cases, the macro htons unfolds to __swab16 which > provides special case for constants. In big endian cases, > __constant_htons and htons expand directly to the same expression. > So, replace __constant_htons with htons with the goal of getting > rid of the definition of __constant_htons completely. > > The semantic patch that performs this transformation is as follows: > > @@expression x;@@ > > - __constant_htons(x) > + htons(x) > > Signed-off-by: Vaishali Thakkar > --- > drivers/scsi/fcoe/fcoe.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/scsi/fcoe/fcoe.c b/drivers/scsi/fcoe/fcoe.c > index ec193a8..d3eb80c 100644 > --- a/drivers/scsi/fcoe/fcoe.c > +++ b/drivers/scsi/fcoe/fcoe.c > @@ -364,7 +364,7 @@ static int fcoe_interface_setup(struct fcoe_interface *fcoe, > * on the ethertype for the given device > */ > fcoe->fcoe_packet_type.func = fcoe_rcv; > - fcoe->fcoe_packet_type.type = __constant_htons(ETH_P_FCOE); > + fcoe->fcoe_packet_type.type = htons(ETH_P_FCOE); > fcoe->fcoe_packet_type.dev = netdev; > dev_add_pack(&fcoe->fcoe_packet_type); > Acked-by: Vasu Dev