From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753988AbbIBKBd (ORCPT ); Wed, 2 Sep 2015 06:01:33 -0400 Received: from foss.arm.com ([217.140.101.70]:35756 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753817AbbIBKB3 (ORCPT ); Wed, 2 Sep 2015 06:01:29 -0400 From: Juri Lelli To: peterz@infradead.org, mingo@redhat.com Cc: linux-kernel@vger.kernel.org, juri.lelli@arm.com Subject: [PATCH 3/4] locking/rtmutex: fix open coded check in rt_mutex_waiter_less() Date: Wed, 2 Sep 2015 11:01:35 +0100 Message-Id: <1441188096-23021-4-git-send-email-juri.lelli@arm.com> X-Mailer: git-send-email 2.2.2 In-Reply-To: <1441188096-23021-1-git-send-email-juri.lelli@arm.com> References: <1441188096-23021-1-git-send-email-juri.lelli@arm.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org rt_mutex_waiter_less() check of tasks deadlines is open coded. Since this is subject to wraparound issues, make it use the correct helper. Cc: Ingo Molnar Cc: Peter Zijlstra Reported-by: Luca Abeni Signed-off-by: Juri Lelli --- kernel/locking/rtmutex.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/kernel/locking/rtmutex.c b/kernel/locking/rtmutex.c index 5674b07..74e072f 100644 --- a/kernel/locking/rtmutex.c +++ b/kernel/locking/rtmutex.c @@ -158,7 +158,8 @@ rt_mutex_waiter_less(struct rt_mutex_waiter *left, * then right waiter has a dl_prio() too. */ if (dl_prio(left->prio)) - return (left->task->dl.deadline < right->task->dl.deadline); + return dl_time_before(left->task->dl.deadline, + right->task->dl.deadline); return 0; } -- 2.2.2