From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753346AbbIBLIO (ORCPT ); Wed, 2 Sep 2015 07:08:14 -0400 Received: from mail-wi0-f173.google.com ([209.85.212.173]:35199 "EHLO mail-wi0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750717AbbIBLIM (ORCPT ); Wed, 2 Sep 2015 07:08:12 -0400 From: Mike Rapoport To: Mark Brown Cc: Greg Kroah-Hartman , LKML , Mike Rapoport Subject: [PATCH] regmap: fix compilation warning Date: Wed, 2 Sep 2015 14:08:07 +0300 Message-Id: <1441192087-5828-1-git-send-email-mike.rapoport@gmail.com> X-Mailer: git-send-email 2.1.0 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Explicitly initialize ret to -EINVAL in regmap_raw_read to fix the following compilation warning: CC drivers/base/regmap/regmap.o linux/drivers/base/regmap/regmap.c: In function ‘regmap_raw_read’: linux/drivers/base/regmap/regmap.c:2174:6: warning: ‘ret’ may be used uninitialized in this function [-Wmaybe-uninitialized] int ret, i; ^ Signed-off-by: Mike Rapoport --- drivers/base/regmap/regmap.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/base/regmap/regmap.c b/drivers/base/regmap/regmap.c index 7111d04..ba0aab4 100644 --- a/drivers/base/regmap/regmap.c +++ b/drivers/base/regmap/regmap.c @@ -2171,14 +2171,15 @@ int regmap_raw_read(struct regmap *map, unsigned int reg, void *val, size_t val_bytes = map->format.val_bytes; size_t val_count = val_len / val_bytes; unsigned int v; - int ret, i; + int i; + int ret = -EINVAL; if (!map->bus) - return -EINVAL; + return ret; if (val_len % map->format.val_bytes) - return -EINVAL; + return ret; if (reg % map->reg_stride) - return -EINVAL; + return ret; map->lock(map->lock_arg); -- 1.8.3.1