From: ulfalizer.lkml@gmail.com
To: linux-kernel@vger.kernel.org
Cc: linux-doc@vger.kernel.org, corbet@lwn.net, harryxiyou@gmail.com,
jlbec@evilplan.org, ulfalizer@gmail.com,
gregkh@linuxfoundation.org, shane.seymour@hp.com, tj@kernel.org,
bvanassche@acm.org, serue@us.ibm.com
Subject: [PATCH 3/3] configfs: fix pre-kernfs sysfs_dirent reference
Date: Wed, 2 Sep 2015 14:34:54 +0200 [thread overview]
Message-ID: <1441197294-11723-4-git-send-email-ulfalizer.lkml@gmail.com> (raw)
In-Reply-To: <1441197294-11723-3-git-send-email-ulfalizer.lkml@gmail.com>
From: Ulf Magnusson <ulfalizer@gmail.com>
sysfs_dirent was renamed in 324a56e16e44 ("kernfs:
s/sysfs_dirent/kernfs_node/ and rename its friends accordingly").
Do s/sysfs_dirent/configfs_dirent/ - possibly a copy-paste error to
begin with. Clean up the language a bit too.
Signed-off-by: Ulf Magnusson <ulfalizer@gmail.com>
---
fs/configfs/inode.c | 11 ++++++-----
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/fs/configfs/inode.c b/fs/configfs/inode.c
index eae8757..e076661 100644
--- a/fs/configfs/inode.c
+++ b/fs/configfs/inode.c
@@ -133,13 +133,14 @@ struct inode *configfs_new_inode(umode_t mode, struct configfs_dirent *sd,
inode->i_mapping->a_ops = &configfs_aops;
inode->i_op = &configfs_inode_operations;
- if (sd->s_iattr) {
- /* sysfs_dirent has non-default attributes
- * get them for the new inode from persistent copy
- * in sysfs_dirent
+ if (sd->s_iattr)
+ /*
+ * configfs_dirent has non-default attributes. Set them
+ * on the new inode from the persistent copy in
+ * configfs_dirent.
*/
set_inode_attr(inode, sd->s_iattr);
- } else
+ else
set_default_inode_attr(inode, mode);
}
return inode;
--
2.1.4
next prev parent reply other threads:[~2015-09-02 12:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-02 12:34 [PATCH 0/3] Fix some outdated pre-kernfs doc references ulfalizer.lkml
2015-09-02 12:34 ` [PATCH 1/3] sysfs.txt: fix pre-kernfs sysfs_dirent reference ulfalizer.lkml
2015-09-02 12:34 ` [PATCH 2/3] sysfs-tagging.txt: fix pre-kernfs references ulfalizer.lkml
2015-09-02 12:34 ` ulfalizer.lkml [this message]
2015-09-12 20:15 ` [PATCH 0/3] Fix some outdated pre-kernfs doc references Jonathan Corbet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1441197294-11723-4-git-send-email-ulfalizer.lkml@gmail.com \
--to=ulfalizer.lkml@gmail.com \
--cc=bvanassche@acm.org \
--cc=corbet@lwn.net \
--cc=gregkh@linuxfoundation.org \
--cc=harryxiyou@gmail.com \
--cc=jlbec@evilplan.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=serue@us.ibm.com \
--cc=shane.seymour@hp.com \
--cc=tj@kernel.org \
--cc=ulfalizer@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®