From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751307AbbICEPH (ORCPT ); Thu, 3 Sep 2015 00:15:07 -0400 Received: from smtpfree.forptr.21cn.com ([183.56.131.105]:47380 "EHLO 21cn.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1750891AbbICEPF (ORCPT ); Thu, 3 Sep 2015 00:15:05 -0400 HMM_SOURCE_IP: 10.64.8.31:30740.1291634738 HMM_ATTACHE_NUM: 0000 HMM_SOURCE_TYPE: SMTP 0/X-Total-Score: 0: 1/X-Total-Score: 0: X-FILTER-SCORE: to=<828c918e618d8a8f96994e8790968f8582958a908f4f909388>, score=<1441253695yvv7vhy7smx4L2vvvvvhvvkkQkMDQPtnA7FkkkkkMkkD> X-REAL-FROM: gchen_5i5j@21cn.com X-Receive-IP: 124.166.242.184 From: gang.chen.5i5j@gmail.com To: akpm@linux-foundation.org, mhocko@suse.cz Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, gchen_5i5j@21cn.com, Chen Gang Subject: [PATCH] mm/mmap.c: Remove redundent 'get_area' function pointer in get_unmapped_area() Date: Thu, 3 Sep 2015 12:14:51 +0800 Message-Id: <1441253691-5798-1-git-send-email-gang.chen.5i5j@gmail.com> X-Mailer: git-send-email 1.9.3 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Chen Gang Call the function pointer directly, then let code a bit simpler. Signed-off-by: Chen Gang --- mm/mmap.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/mm/mmap.c b/mm/mmap.c index 4db7cf0..39fd727 100644 --- a/mm/mmap.c +++ b/mm/mmap.c @@ -2012,10 +2012,8 @@ unsigned long get_unmapped_area(struct file *file, unsigned long addr, unsigned long len, unsigned long pgoff, unsigned long flags) { - unsigned long (*get_area)(struct file *, unsigned long, - unsigned long, unsigned long, unsigned long); - unsigned long error = arch_mmap_check(addr, len, flags); + if (error) return error; @@ -2023,10 +2021,12 @@ get_unmapped_area(struct file *file, unsigned long addr, unsigned long len, if (len > TASK_SIZE) return -ENOMEM; - get_area = current->mm->get_unmapped_area; if (file && file->f_op->get_unmapped_area) - get_area = file->f_op->get_unmapped_area; - addr = get_area(file, addr, len, pgoff, flags); + addr = file->f_op->get_unmapped_area(file, addr, len, + pgoff, flags); + else + addr = current->mm->get_unmapped_area(file, addr, len, + pgoff, flags); if (IS_ERR_VALUE(addr)) return addr; -- 1.9.3