From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754736AbbICLcl (ORCPT ); Thu, 3 Sep 2015 07:32:41 -0400 Received: from mx2.parallels.com ([199.115.105.18]:55792 "EHLO mx2.parallels.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754555AbbICLci (ORCPT ); Thu, 3 Sep 2015 07:32:38 -0400 From: Andrey Ryabinin To: Herbert Xu , "David S. Miller" , CC: Andrey Ryabinin , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , , Subject: [PATCH] x86/crypto/ghash-intel: specify context size for ghash async algorithm Date: Thu, 3 Sep 2015 14:32:01 +0300 Message-ID: <1441279921-26838-2-git-send-email-aryabinin@odin.com> X-Mailer: git-send-email 2.4.6 In-Reply-To: <1441279921-26838-1-git-send-email-aryabinin@odin.com> References: <1441279921-26838-1-git-send-email-aryabinin@odin.com> MIME-Version: 1.0 Content-Type: text/plain X-ClientProxiedBy: US-EXCH2.sw.swsoft.com (10.255.249.46) To US-EXCH2.sw.swsoft.com (10.255.249.46) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Currently context size (cra_ctxsize) doesn't specified for ghash_async_alg. Which means it's zero. Thus crypto_create_tfm() doesn't allocate needed space for ghash_async_ctx, so any read/write to ctx (e.g. in ghash_async_init_tfm()) is not valid. Signed-off-by: Andrey Ryabinin --- arch/x86/crypto/ghash-clmulni-intel_glue.c | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/x86/crypto/ghash-clmulni-intel_glue.c b/arch/x86/crypto/ghash-clmulni-intel_glue.c index 64d7cf1..440df0c 100644 --- a/arch/x86/crypto/ghash-clmulni-intel_glue.c +++ b/arch/x86/crypto/ghash-clmulni-intel_glue.c @@ -294,6 +294,7 @@ static struct ahash_alg ghash_async_alg = { .cra_name = "ghash", .cra_driver_name = "ghash-clmulni", .cra_priority = 400, + .cra_ctxsize = sizeof(struct ghash_async_ctx), .cra_flags = CRYPTO_ALG_TYPE_AHASH | CRYPTO_ALG_ASYNC, .cra_blocksize = GHASH_BLOCK_SIZE, .cra_type = &crypto_ahash_type, -- 2.4.6