From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932435AbbICOvI (ORCPT ); Thu, 3 Sep 2015 10:51:08 -0400 Received: from mail-pa0-f48.google.com ([209.85.220.48]:35648 "EHLO mail-pa0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932278AbbICOvF (ORCPT ); Thu, 3 Sep 2015 10:51:05 -0400 From: Sudip Mukherjee To: Dimitri Sivanich , Arnd Bergmann , Greg Kroah-Hartman Cc: linux-kernel@vger.kernel.org, Sudip Mukherjee Subject: [PATCH v2 3/5] drivers/misc/sgi-gru: remove always false condition Date: Thu, 3 Sep 2015 20:20:49 +0530 Message-Id: <1441291851-29411-3-git-send-email-sudipm.mukherjee@gmail.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1441291851-29411-1-git-send-email-sudipm.mukherjee@gmail.com> References: <1441291851-29411-1-git-send-email-sudipm.mukherjee@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The member gid in struct gru_dump_chiplet_state_req is unsigned int. So it can never be less than 0. Signed-off-by: Sudip Mukherjee Acked-by: Dimitri Sivanich --- v2: no change, sent as a part of the series. drivers/misc/sgi-gru/grukdump.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/misc/sgi-gru/grukdump.c b/drivers/misc/sgi-gru/grukdump.c index 7e9aae5..313da31 100644 --- a/drivers/misc/sgi-gru/grukdump.c +++ b/drivers/misc/sgi-gru/grukdump.c @@ -194,7 +194,7 @@ int gru_dump_chiplet_request(unsigned long arg) return -EFAULT; /* Currently, only dump by gid is implemented */ - if (req.gid >= gru_max_gids || req.gid < 0) + if (req.gid >= gru_max_gids) return -EINVAL; gru = GID_TO_GRU(req.gid); -- 1.9.1