From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756472AbbIDDkL (ORCPT ); Thu, 3 Sep 2015 23:40:11 -0400 Received: from smtprelay0210.hostedemail.com ([216.40.44.210]:58152 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754190AbbIDDkJ (ORCPT ); Thu, 3 Sep 2015 23:40:09 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::::,RULES_HIT:41:355:379:541:599:968:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1539:1568:1593:1594:1711:1714:1730:1747:1777:1792:1981:2194:2199:2393:2559:2562:2828:3138:3139:3140:3141:3142:3622:3868:4321:5007:6119:6120:6261:7903:10004:10400:10848:11026:11232:11658:11914:12043:12296:12517:12519:12740:13069:13255:13311:13357:21080,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0 X-HE-Tag: cakes93_116462314144 X-Filterd-Recvd-Size: 1696 Message-ID: <1441338006.9666.38.camel@perches.com> Subject: Re: [RFC PATCH 2/3] clocksource: mtk_timer: change pr_warn()s to pr_err()s in mtk_timer_init From: Joe Perches To: Alexey Klimov Cc: daniel.lezcano@linaro.org, linux-mediatek@lists.infradead.org, matthias.bgg@gmail.com, yingjoe.chen@mediatek.com, tglx@linutronix.de, linux-kernel@vger.kernel.org, klimov.linux@gmail.com Date: Thu, 03 Sep 2015 20:40:06 -0700 In-Reply-To: <1441336900-15095-2-git-send-email-alexey.klimov@linaro.org> References: <1441336900-15095-1-git-send-email-alexey.klimov@linaro.org> <1441336900-15095-2-git-send-email-alexey.klimov@linaro.org> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.12.11-0ubuntu3 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2015-09-04 at 06:21 +0300, Alexey Klimov wrote: > These messages are actually errors and not warnings. > Use pr_err() macro for them and add missing \n. [] > diff --git a/drivers/clocksource/mtk_timer.c b/drivers/clocksource/mtk_timer.c [] > @@ -184,7 +184,7 @@ static void __init mtk_timer_init(struct device_node *node) > > evt = kzalloc(sizeof(*evt), GFP_KERNEL); > if (!evt) { > - pr_warn("Can't allocate mtk clock event driver struct"); > + pr_err("Can't allocate mtk clock event driver struct\n"); > return; > } Might as well remove this one as there's a generic stack_dump() on alloc failures.