From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756927AbbIDHzI (ORCPT ); Fri, 4 Sep 2015 03:55:08 -0400 Received: from LGEMRELSE6Q.lge.com ([156.147.1.121]:47787 "EHLO lgemrelse6q.lge.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753206AbbIDHzG (ORCPT ); Fri, 4 Sep 2015 03:55:06 -0400 X-Original-SENDERIP: 10.177.222.170 X-Original-MAILFROM: namhyung@kernel.org From: Namhyung Kim To: Arnaldo Carvalho de Melo Cc: Ingo Molnar , Peter Zijlstra , Jiri Olsa , LKML , Wang Nan , pi3orama@163.com, Masami Hiramatsu Subject: [PATCH 1/5] perf probe: Split add_perf_probe_events() Date: Fri, 4 Sep 2015 16:39:34 +0900 Message-Id: <1441352378-17988-1-git-send-email-namhyung@kernel.org> X-Mailer: git-send-email 2.5.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The add_perf_probe_events() does 3 things: 1. convert all perf events to trace events 2. add all trace events to kernel 3. cleanup all trace events But sometimes we need to do something with the trace events. So split the funtion into three, so that it can access intermediate trace events via struct __event_package if needed. Acked-by: Masami Hiramatsu Signed-off-by: Namhyung Kim --- tools/perf/util/probe-event.c | 39 +++++++++++++++++++++++++++++++++++---- 1 file changed, 35 insertions(+), 4 deletions(-) diff --git a/tools/perf/util/probe-event.c b/tools/perf/util/probe-event.c index eb5f18b75402..2c762f41e7a5 100644 --- a/tools/perf/util/probe-event.c +++ b/tools/perf/util/probe-event.c @@ -2765,9 +2765,10 @@ struct __event_package { int ntevs; }; -int add_perf_probe_events(struct perf_probe_event *pevs, int npevs) +static int convert_perf_probe_events(struct perf_probe_event *pevs, int npevs, + struct __event_package **ppkgs) { - int i, j, ret; + int i, ret; struct __event_package *pkgs; ret = 0; @@ -2792,12 +2793,21 @@ int add_perf_probe_events(struct perf_probe_event *pevs, int npevs) ret = convert_to_probe_trace_events(pkgs[i].pev, &pkgs[i].tevs); if (ret < 0) - goto end; + return ret; pkgs[i].ntevs = ret; } /* This just release blacklist only if allocated */ kprobe_blacklist__release(); + *ppkgs = pkgs; + + return 0; +} + +static int apply_perf_probe_events(struct __event_package *pkgs, int npevs) +{ + int i, ret = 0; + /* Loop 2: add all events */ for (i = 0; i < npevs; i++) { ret = __add_probe_trace_events(pkgs[i].pev, pkgs[i].tevs, @@ -2806,7 +2816,16 @@ int add_perf_probe_events(struct perf_probe_event *pevs, int npevs) if (ret < 0) break; } -end: + return ret; +} + +static void cleanup_perf_probe_events(struct __event_package *pkgs, int npevs) +{ + int i, j; + + if (pkgs == NULL) + return; + /* Loop 3: cleanup and free trace events */ for (i = 0; i < npevs; i++) { for (j = 0; j < pkgs[i].ntevs; j++) @@ -2815,6 +2834,18 @@ int add_perf_probe_events(struct perf_probe_event *pevs, int npevs) } free(pkgs); exit_symbol_maps(); +} + +int add_perf_probe_events(struct perf_probe_event *pevs, int npevs) +{ + int ret; + struct __event_package *pkgs = NULL; + + ret = convert_perf_probe_events(pevs, npevs, &pkgs); + if (ret == 0) + ret = apply_perf_probe_events(pkgs, npevs); + + cleanup_perf_probe_events(pkgs, npevs); return ret; } -- 2.5.0