From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758259AbbIDLWu (ORCPT ); Fri, 4 Sep 2015 07:22:50 -0400 Received: from mail-pa0-f42.google.com ([209.85.220.42]:34805 "EHLO mail-pa0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750973AbbIDLWt (ORCPT ); Fri, 4 Sep 2015 07:22:49 -0400 From: Sudip Mukherjee To: Alasdair Kergon , Mike Snitzer , dm-devel@redhat.com, Neil Brown Cc: linux-kernel@vger.kernel.org, linux-raid@vger.kernel.org, Sudip Mukherjee Subject: [PATCH] dm: ioctl: prevent double freeing Date: Fri, 4 Sep 2015 16:52:39 +0530 Message-Id: <1441365759-7247-1-git-send-email-sudipm.mukherjee@gmail.com> X-Mailer: git-send-email 1.9.1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org DM_PARAMS_KMALLOC and DM_PARAMS_VMALLOC should never be set together in param_flags. We are setting these flags while allocating so we know that there is almost no chance of having these two set together but still we can have some additional safety. Signed-off-by: Sudip Mukherjee --- drivers/md/dm-ioctl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/md/dm-ioctl.c b/drivers/md/dm-ioctl.c index 80a4395..aaad74e 100644 --- a/drivers/md/dm-ioctl.c +++ b/drivers/md/dm-ioctl.c @@ -1680,7 +1680,7 @@ static void free_params(struct dm_ioctl *param, size_t param_size, int param_fla if (param_flags & DM_PARAMS_KMALLOC) kfree(param); - if (param_flags & DM_PARAMS_VMALLOC) + else if (param_flags & DM_PARAMS_VMALLOC) vfree(param); } -- 1.9.1