mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Vitaly Kuznetsov <vkuznets@redhat.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Rasmus Villemoes <linux@rasmusvillemoes.dk>,
	James Bottomley <JBottomley@Odin.com>,
	linux-kernel@vger.kernel.org,
	"K. Y. Srinivasan" <kys@microsoft.com>
Subject: [PATCH] lib/string_helpers.c: fix infinite loop in string_get_size()
Date: Fri,  4 Sep 2015 14:56:33 +0200	[thread overview]
Message-ID: <1441371393-15030-1-git-send-email-vkuznets@redhat.com> (raw)

string_get_size(1, 512, 0, ..., ...) call results in an infinite loop. The
problem is that if size == 0 when we start calculating sf_cap this loop
will never end.

The caller causing the issue is sd_read_capacity(), the problem was noticed
on Hyper-V.

Signed-off-by: Vitaly Kuznetsov <vkuznets@redhat.com>
---
 lib/string_helpers.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/string_helpers.c b/lib/string_helpers.c
index c98ae81..a155c7b 100644
--- a/lib/string_helpers.c
+++ b/lib/string_helpers.c
@@ -76,7 +76,7 @@ void string_get_size(u64 size, u64 blk_size, const enum string_size_units units,
 		i++;
 	}
 
-	sf_cap = size;
+	sf_cap = size ? size : 1;
 	for (j = 0; sf_cap*10 < 1000; j++)
 		sf_cap *= 10;
 
-- 
2.4.3


             reply	other threads:[~2015-09-04 12:56 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-04 12:56 Vitaly Kuznetsov [this message]
2015-09-10 23:08 ` Andrew Morton
2015-09-11 18:31   ` James Bottomley
2015-09-14  9:06     ` Andy Shevchenko
2015-09-14 12:43       ` Vitaly Kuznetsov
2015-09-14 14:33         ` Andy Shevchenko
2015-09-14  9:16     ` Vitaly Kuznetsov
2015-09-11  1:22 ` James Bottomley
2015-09-14  9:19   ` Vitaly Kuznetsov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1441371393-15030-1-git-send-email-vkuznets@redhat.com \
    --to=vkuznets@redhat.com \
    --cc=JBottomley@Odin.com \
    --cc=akpm@linux-foundation.org \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=kys@microsoft.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@rasmusvillemoes.dk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®