From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753907AbbIGIiN (ORCPT ); Mon, 7 Sep 2015 04:38:13 -0400 Received: from mx1.redhat.com ([209.132.183.28]:60390 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751091AbbIGIiL (ORCPT ); Mon, 7 Sep 2015 04:38:11 -0400 From: Jiri Olsa To: Arnaldo Carvalho de Melo Cc: lkml , David Ahern , Ingo Molnar , Namhyung Kim , Peter Zijlstra , Matt Fleming , =?UTF-8?q?Rapha=C3=ABl=20Beamonte?= Subject: [PATCHv2 0/5] perf tools: Enhance parsing events tracepoint error output Date: Mon, 7 Sep 2015 10:38:02 +0200 Message-Id: <1441615087-13886-1-git-send-email-jolsa@kernel.org> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org hi, enhancing parsing events tracepoint error output. Adding more verbose output when the tracepoint is not found or the tracing event path cannot be access. $ sudo perf record -e sched:sched_krava ls event syntax error: 'sched:sched_krava' \___ unknown tracepoint Error: File /sys/kernel/debug/tracing//tracing/events/sched/sched_krava not found. Hint: Perhaps this kernel misses some CONFIG_ setting to enable this feature?. Run 'perf list' for a list of valid events ... $ perf record -e sched:sched_krava ls event syntax error: 'sched:sched_krava' \___ can't access trace events Error: No permissions to read /sys/kernel/debug/tracing//tracing/events/sched/sched_krava Hint: Try 'sudo mount -o remount,mode=755 /sys/kernel/debug' Run 'perf list' for a list of valid events ... v2 changes: - debugfs/tracefs changes went already in through separate patchset - more commentary on err.h interface - fixed callers of err.h enhanced functions - added extra tags/cscope fix Also available in: git://git.kernel.org/pub/scm/linux/kernel/git/jolsa/perf.git perf/tp thanks, jirka --- Jiri Olsa (5): tools: Add err.h with ERR_PTR PTR_ERR interface perf tools: Add tools/include into tags directories perf tools: Propagate error info for the tracepoint parsing perf tools: Propagate error info from tp_format perf tools: Enhance parsing events tracepoint error output tools/include/linux/err.h | 49 +++++++++++++++++++++++++++++++++++++++++++++++++ tools/perf/Makefile.perf | 2 +- tools/perf/builtin-trace.c | 19 +++++++++++-------- tools/perf/tests/evsel-tp-sched.c | 10 ++++++++-- tools/perf/tests/openat-syscall-all-cpus.c | 3 ++- tools/perf/tests/openat-syscall-tp-fields.c | 3 ++- tools/perf/tests/openat-syscall.c | 3 ++- tools/perf/util/evlist.c | 3 ++- tools/perf/util/evsel.c | 11 +++++++++-- tools/perf/util/evsel.h | 3 +++ tools/perf/util/parse-events.c | 66 ++++++++++++++++++++++++++++++++++++++++++++++++++---------------- tools/perf/util/parse-events.h | 3 ++- tools/perf/util/parse-events.y | 16 +++++++++------- tools/perf/util/trace-event.c | 13 +++++++++++-- 14 files changed, 161 insertions(+), 43 deletions(-) create mode 100644 tools/include/linux/err.h