From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752742AbbIHFja (ORCPT ); Tue, 8 Sep 2015 01:39:30 -0400 Received: from ozlabs.org ([103.22.144.67]:60613 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751094AbbIHFj0 (ORCPT ); Tue, 8 Sep 2015 01:39:26 -0400 Message-ID: <1441690765.14597.11.camel@ellerman.id.au> Subject: Re: [PATCH v2 1/6] selftests: rename jump label to static_keys From: Michael Ellerman To: Bamvor Jian Zhang Cc: linux-kernel@vger.kernel.org, broonie@kernel.org, khilman@linaro.org, tyler.baker@linaro.org, shuahkh@osg.samsung.com, peterz@infradead.org, mingo@kernel.org Date: Tue, 08 Sep 2015 15:39:25 +1000 In-Reply-To: <1441634692-19494-2-git-send-email-bamvor.zhangjian@linaro.org> References: <1441634692-19494-1-git-send-email-bamvor.zhangjian@linaro.org> <1441634692-19494-2-git-send-email-bamvor.zhangjian@linaro.org> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.12.11-0ubuntu3 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2015-09-07 at 22:04 +0800, Bamvor Jian Zhang wrote: > commit "2bf9e0a locking/static_keys: Provide a selftest" rename ^ d > jump_label directory to static_keys. ... "and failed to update the Makefile, causing the selftests build to fail. This commit fixes it by updating the Makefile with the new name and also moves the entry into the correct position to keep the list alphabetically sorted." Also the proper syntax for quoting a commit is: Commit 2bf9e0ab08c6 ("locking/static_keys: Provide a selftest") And ideally you also include a line saying: Fixes: 2bf9e0ab08c6 ("locking/static_keys: Provide a selftest") > Signed-off-by: Bamvor Jian Zhang > --- > tools/testing/selftests/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/testing/selftests/Makefile b/tools/testing/selftests/Makefile > index ac40ec9..8922c21 100644 > --- a/tools/testing/selftests/Makefile > +++ b/tools/testing/selftests/Makefile > @@ -17,12 +17,12 @@ TARGETS += powerpc > TARGETS += ptrace > TARGETS += seccomp > TARGETS += size > +TARGETS += static_keys > TARGETS += sysctl > ifneq (1, $(quicktest)) > TARGETS += timers > endif > TARGETS += user > -TARGETS += jumplabel > TARGETS += vm > TARGETS += x86 > TARGETS += zram Otherwise: Acked-by: Michael Ellerman cheers