From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752758AbbIHFoI (ORCPT ); Tue, 8 Sep 2015 01:44:08 -0400 Received: from ozlabs.org ([103.22.144.67]:35136 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751607AbbIHFoG (ORCPT ); Tue, 8 Sep 2015 01:44:06 -0400 Message-ID: <1441691044.14597.13.camel@ellerman.id.au> Subject: Re: [PATCH v2 3/6] selftests: mqueue: allow extra cflags From: Michael Ellerman To: Bamvor Jian Zhang Cc: linux-kernel@vger.kernel.org, broonie@kernel.org, khilman@linaro.org, tyler.baker@linaro.org, shuahkh@osg.samsung.com Date: Tue, 08 Sep 2015 15:44:04 +1000 In-Reply-To: <1441634692-19494-4-git-send-email-bamvor.zhangjian@linaro.org> References: <1441634692-19494-1-git-send-email-bamvor.zhangjian@linaro.org> <1441634692-19494-4-git-send-email-bamvor.zhangjian@linaro.org> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.12.11-0ubuntu3 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2015-09-07 at 22:04 +0800, Bamvor Jian Zhang wrote: > change from = to += in order to pass the proper headers and librareis Please start your changelogs with a Capital letter, they are supposed to be proper English sentences. > (popt.h and libpopt.so) in order to build successful in cross > compiling. Yeah. More generally it allows the user to pass whatever CFLAGS they wish, which is a good feature. Acked-by: Michael Ellerman cheers