From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753030AbbIHFrg (ORCPT ); Tue, 8 Sep 2015 01:47:36 -0400 Received: from ozlabs.org ([103.22.144.67]:48907 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751455AbbIHFrd (ORCPT ); Tue, 8 Sep 2015 01:47:33 -0400 Message-ID: <1441691252.14597.14.camel@ellerman.id.au> Subject: Re: [PATCH v2 4/6] selftests: mqueue: simpification the Makefile From: Michael Ellerman To: Bamvor Jian Zhang Cc: linux-kernel@vger.kernel.org, broonie@kernel.org, khilman@linaro.org, tyler.baker@linaro.org, shuahkh@osg.samsung.com Date: Tue, 08 Sep 2015 15:47:32 +1000 In-Reply-To: <1441634692-19494-5-git-send-email-bamvor.zhangjian@linaro.org> References: <1441634692-19494-1-git-send-email-bamvor.zhangjian@linaro.org> <1441634692-19494-5-git-send-email-bamvor.zhangjian@linaro.org> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.12.11-0ubuntu3 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2015-09-07 at 22:04 +0800, Bamvor Jian Zhang wrote: > selftests: mqueue: simpification the Makefile This should be: selftests/mqueue: Simplify the Makefile And please write a change log, even for simple commits like this. You can say something like: Use make's implict rule for building simple C programs. > Suggested-by: Michael Ellermani > Signed-off-by: Bamvor Jian Zhang > --- > tools/testing/selftests/mqueue/Makefile | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/tools/testing/selftests/mqueue/Makefile b/tools/testing/selftests/mqueue/Makefile > index ca8327f..9f51aaa 100644 > --- a/tools/testing/selftests/mqueue/Makefile > +++ b/tools/testing/selftests/mqueue/Makefile > @@ -1,8 +1,7 @@ > CFLAGS += -O2 > +LDLIBS = -lrt -lpthread -lpopt Please move the TEST_PROGS line here: TEST_PROGS := mq_open_tests mq_perf_tests > -all: > - $(CC) $(CFLAGS) mq_open_tests.c -o mq_open_tests -lrt > - $(CC) $(CFLAGS) -o mq_perf_tests mq_perf_tests.c -lrt -lpthread -lpopt > +all: mq_open_tests mq_perf_tests So this can become: all: $(TEST_PROGS) > > include ../lib.mk cheers