From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752843AbbIHF5M (ORCPT ); Tue, 8 Sep 2015 01:57:12 -0400 Received: from ozlabs.org ([103.22.144.67]:44808 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751435AbbIHF5I (ORCPT ); Tue, 8 Sep 2015 01:57:08 -0400 Message-ID: <1441691826.14597.16.camel@ellerman.id.au> Subject: Re: [PATCH v2 6/6] selftests: exec: simpification the Makefile From: Michael Ellerman To: Bamvor Jian Zhang Cc: linux-kernel@vger.kernel.org, broonie@kernel.org, khilman@linaro.org, tyler.baker@linaro.org, shuahkh@osg.samsung.com Date: Tue, 08 Sep 2015 15:57:06 +1000 In-Reply-To: <1441634692-19494-7-git-send-email-bamvor.zhangjian@linaro.org> References: <1441634692-19494-1-git-send-email-bamvor.zhangjian@linaro.org> <1441634692-19494-7-git-send-email-bamvor.zhangjian@linaro.org> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.12.11-0ubuntu3 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2015-09-07 at 22:04 +0800, Bamvor Jian Zhang wrote: > selftests: exec: simpification the Makefile Please give us a better subject, ie something like: selftests/exec: Revert to default emit rule > With the previous patch, the installation method change from install > to rsync. There is not no need to create subdir during test, the ^ one too many "not" > default RUN_TESTS is enough. ^ EMIT_TESTS > > This patch implicitly revert commit 84cbd9e4 ("selftests/exec: do not ^ "essentially" would be more accurate I think > install subdir as it is already created"). cheers