From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754640AbbIHJjy (ORCPT ); Tue, 8 Sep 2015 05:39:54 -0400 Received: from ozlabs.org ([103.22.144.67]:57670 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754585AbbIHJjH (ORCPT ); Tue, 8 Sep 2015 05:39:07 -0400 Message-ID: <1441705144.7601.8.camel@ellerman.id.au> Subject: Re: [PATCH v2 5/6] selftests: change install command to rsync From: Michael Ellerman To: Bamvor Zhang Jian Cc: linux-kernel@vger.kernel.org, broonie@kernel.org, khilman@linaro.org, tyler.baker@linaro.org, shuahkh@osg.samsung.com Date: Tue, 08 Sep 2015 19:39:04 +1000 In-Reply-To: <55EEA994.8060207@linaro.org> References: <1441634692-19494-1-git-send-email-bamvor.zhangjian@linaro.org> <1441634692-19494-6-git-send-email-bamvor.zhangjian@linaro.org> <1441691528.14597.15.camel@ellerman.id.au> <55EEA994.8060207@linaro.org> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.12.11-0ubuntu3 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2015-09-08 at 17:25 +0800, Bamvor Zhang Jian wrote: > Hi, Michael > > On 09/08/2015 01:52 PM, Michael Ellerman wrote: > > On Mon, 2015-09-07 at 22:04 +0800, Bamvor Jian Zhang wrote: > >> The command of install could not handle the special files in exec > >> testcases, change the default rule to rsync to fix this. > >> The result of installation is unchanged after this commit. > >> > >> Suggested-by: Michael Ellerman > >> Signed-off-by: Bamvor Jian Zhang > > > > Ah OK, I did suggest it. You never replied to my mail suggesting it though. > > > > I assume you tested it and it worked for all cases? > yes, I compare the installed file. OK, thanks. > >> diff --git a/tools/testing/selftests/ftrace/Makefile b/tools/testing/selftests/ftrace/Makefile > >> index 0acbeca..4e6ed13 100644 > >> --- a/tools/testing/selftests/ftrace/Makefile > >> +++ b/tools/testing/selftests/ftrace/Makefile > >> @@ -1,7 +1,7 @@ > >> all: > >> > >> TEST_PROGS := ftracetest > >> -TEST_DIRS := test.d/ > >> +TEST_DIRS := test.d > >> > >> include ../lib.mk > >> > >> diff --git a/tools/testing/selftests/lib.mk b/tools/testing/selftests/lib.mk > >> index 97f1c67..50a93f5 100644 > >> --- a/tools/testing/selftests/lib.mk > >> +++ b/tools/testing/selftests/lib.mk > >> @@ -12,13 +12,10 @@ run_tests: all > >> $(RUN_TESTS) > >> > >> define INSTALL_RULE > >> - @if [ "X$(TEST_PROGS)$(TEST_PROGS_EXTENDED)$(TEST_FILES)" != "X" ]; then \ > >> - mkdir -p $(INSTALL_PATH); \ > >> - for TEST_DIR in $(TEST_DIRS); do \ > >> - cp -r $$TEST_DIR $(INSTALL_PATH); \ > >> - done; \ > >> - echo "install -t $(INSTALL_PATH) $(TEST_PROGS) $(TEST_PROGS_EXTENDED) $(TEST_FILES)"; \ > >> - install -t $(INSTALL_PATH) $(TEST_PROGS) $(TEST_PROGS_EXTENDED) $(TEST_FILES); \ > >> + @if [ "X$(TEST_PROGS)$(TEST_PROGS_EXTENDED)$(TEST_FILES)" != "X" ]; then \ > >> + mkdir -p ${INSTALL_PATH}; \ > >> + echo "rsync -a $(TEST_DIRS) $(TEST_PROGS) $(TEST_PROGS_EXTENDED) $(TEST_FILES) $(INSTALL_PATH)/"; \ > > > > What is the echo for? > For output the following rsync command during building. > Do you mean there is some better way to do it? No, I mean we didn't used to do that, until your recent patch. It's just for logging? cheers