From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754937AbbIHNuJ (ORCPT ); Tue, 8 Sep 2015 09:50:09 -0400 Received: from fw-tnat.cambridge.arm.com ([217.140.96.140]:59001 "EHLO cam-smtp0.cambridge.arm.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754175AbbIHNuG (ORCPT ); Tue, 8 Sep 2015 09:50:06 -0400 From: Punit Agrawal To: edubezval@gmail.com, rui.zhang@intel.com Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, linux@roeck-us.net, Punit Agrawal Subject: [PATCH] thermal: Fix thermal_zone_of_sensor_register to match documentation Date: Tue, 8 Sep 2015 14:51:12 +0100 Message-Id: <1441720272-17338-1-git-send-email-punit.agrawal@arm.com> X-Mailer: git-send-email 2.5.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org thermal_zone_of_sensor_register is documented as returning a pointer to either a valid thermal_zone_device on success, or a corresponding ERR_PTR() value. In contrast, the function returns NULL when THERMAL_OF is configured off. Fix this. Signed-off-by: Punit Agrawal Acked-by: Guenter Roeck Cc: Eduardo Valentin Cc: Zhang Rui --- Hi Eduardo, Rui, This patch has been on the list without any objection for sometime [0] now. Could you pick this up for the next rc please? Thanks, Punit [0] http://thread.gmane.org/gmane.linux.kernel/2011466/focus=2013175 include/linux/thermal.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/thermal.h b/include/linux/thermal.h index 037e9df..f344e51 100644 --- a/include/linux/thermal.h +++ b/include/linux/thermal.h @@ -364,7 +364,7 @@ static inline struct thermal_zone_device * thermal_zone_of_sensor_register(struct device *dev, int id, void *data, const struct thermal_zone_of_device_ops *ops) { - return NULL; + return ERR_PTR(-ENODEV); } static inline -- 2.5.0