mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Wang Long <long.wanglong@huawei.com>
To: <ryabinin.a.a@gmail.com>, <adech.fo@gmail.com>
Cc: <akpm@linux-foundation.org>, <rusty@rustcorp.com.au>,
	<long.wanglong@huawei.com>, <linux-mm@kvack.org>,
	<linux-kernel@vger.kernel.org>, <wanglong@laoqinren.net>,
	<peifeiyue@huawei.com>, <morgan.wang@huawei.com>
Subject: [PATCH 2/2] kasan: Fix a type conversion error
Date: Wed, 9 Sep 2015 03:59:40 +0000	[thread overview]
Message-ID: <1441771180-206648-3-git-send-email-long.wanglong@huawei.com> (raw)
In-Reply-To: <1441771180-206648-1-git-send-email-long.wanglong@huawei.com>

The current KASAN code can find the following out-of-bounds
bugs:
	char *ptr;
	ptr = kmalloc(8, GFP_KERNEL);
	memset(ptr+7, 0, 2);

the cause of the problem is the type conversion error in
*memory_is_poisoned_n* function. So this patch fix that.

Signed-off-by: Wang Long <long.wanglong@huawei.com>
---
 mm/kasan/kasan.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mm/kasan/kasan.c b/mm/kasan/kasan.c
index 7b28e9c..5d65d06 100644
--- a/mm/kasan/kasan.c
+++ b/mm/kasan/kasan.c
@@ -204,7 +204,7 @@ static __always_inline bool memory_is_poisoned_n(unsigned long addr,
 		s8 *last_shadow = (s8 *)kasan_mem_to_shadow((void *)last_byte);
 
 		if (unlikely(ret != (unsigned long)last_shadow ||
-			((last_byte & KASAN_SHADOW_MASK) >= *last_shadow)))
+			((long)(last_byte & KASAN_SHADOW_MASK) >= *last_shadow)))
 			return true;
 	}
 	return false;
-- 
1.8.3.4


  parent reply	other threads:[~2015-09-09  4:00 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-09  3:59 [PATCH 0/2] KASAN: fix a type conversion error and add test Wang Long
2015-09-09  3:59 ` [PATCH 1/2] lib: test_kasan: add some testcases Wang Long
2015-09-09 10:10   ` Andrey Ryabinin
2015-09-09  3:59 ` Wang Long [this message]
2015-09-09  9:01   ` [PATCH 2/2] kasan: Fix a type conversion error Vladimir Murzin
2015-09-09  9:25     ` long.wanglong
2015-09-09  9:40   ` Andrey Ryabinin
2015-09-09 10:22     ` long.wanglong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1441771180-206648-3-git-send-email-long.wanglong@huawei.com \
    --to=long.wanglong@huawei.com \
    --cc=adech.fo@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=morgan.wang@huawei.com \
    --cc=peifeiyue@huawei.com \
    --cc=rusty@rustcorp.com.au \
    --cc=ryabinin.a.a@gmail.com \
    --cc=wanglong@laoqinren.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®