From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754085AbbIIIgx (ORCPT ); Wed, 9 Sep 2015 04:36:53 -0400 Received: from ozlabs.org ([103.22.144.67]:38766 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752112AbbIIIgr (ORCPT ); Wed, 9 Sep 2015 04:36:47 -0400 Message-ID: <1441787804.4703.2.camel@ellerman.id.au> Subject: Re: [PATCH v3] Cleanup: membarrier selftest From: Michael Ellerman To: Mathieu Desnoyers Cc: Andrew Morton , linux-kernel@vger.kernel.org, linux-api@vger.kernel.org, Pranith Kumar , Shuah Khan Date: Wed, 09 Sep 2015 18:36:44 +1000 In-Reply-To: <1441745890-25852-1-git-send-email-mathieu.desnoyers@efficios.com> References: <1441745890-25852-1-git-send-email-mathieu.desnoyers@efficios.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.12.11-0ubuntu3 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2015-09-08 at 16:58 -0400, Mathieu Desnoyers wrote: > We don't need to specify an explicit rule in the Makefile, the implicit > one will do the same. The "__EXPORTED_HEADERS__" define is not needed, > because we build the test against the installed kernel headers, not the > in-tree kernel headers. Re-use "$(TEST_PROGS)" in the clean target > rather than spelling the executable name twice. Include > rather than the rather specific . Include > rather than . In both cases, the former > header is located in a standard location and includes the latter. > > Signed-off-by: Mathieu Desnoyers > CC: Michael Ellerman > CC: Andrew Morton > CC: linux-api@vger.kernel.org > CC: Pranith Kumar > CC: Shuah Khan > -- > Changes since v2: > - Refine Changelog, removing references to comments, taking care > of comments from Shuah Khan. > Changes since v1: > - Add Changelog. > Changes since RFC: > - Take care of comments from Michael Ellerman. Looks great, thanks. Acked-by: Michael Ellerman cheers