From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754414AbbIIInT (ORCPT ); Wed, 9 Sep 2015 04:43:19 -0400 Received: from ozlabs.org ([103.22.144.67]:36541 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752907AbbIIInO (ORCPT ); Wed, 9 Sep 2015 04:43:14 -0400 Message-ID: <1441788191.4703.3.camel@ellerman.id.au> Subject: Re: [PATCH 6/7] selftests: only compile userfaultfd for x86 and powperpc From: Michael Ellerman To: Andrea Arcangeli Cc: Bamvor Zhang Jian , linux-kernel@vger.kernel.org, Mark Brown , khilman@linaro.org, tyler.baker@linaro.org, shuahkh@osg.samsung.com Date: Wed, 09 Sep 2015 18:43:11 +1000 In-Reply-To: <20150908143407.GA10639@redhat.com> References: <1439559818-21666-1-git-send-email-bamvor.zhangjian@linaro.org> <1439559818-21666-7-git-send-email-bamvor.zhangjian@linaro.org> <1440991580.5735.4.camel@ellerman.id.au> <55EEA731.5090708@linaro.org> <1441706053.7601.9.camel@ellerman.id.au> <55EED3C9.2090007@linaro.org> <20150908143407.GA10639@redhat.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.12.11-0ubuntu3 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2015-09-08 at 16:34 +0200, Andrea Arcangeli wrote: > > I already had a few minor changes queued to be submitted for arm and > ppc and a few updates to the selftest. > > I didn't like that you had to remember running make headers_install > for changes like the below one to build, so I added the dependency so > that "make" still works without having to run other commands before > it. These aren't reviewed yet. > > https://git.kernel.org/cgit/linux/kernel/git/andrea/aa.git/commit/?id=5ce2efeb91b501aa1bc7370f43732681fa9123e2 That's, how should I put it, fairly gross :) I'd really rather you didn't do that. It's really not that hard to run make headers_install once manually is it? > I was planning to send these non-x86 updates to Andrew for review and > merging... Fine by me, that's probably the best way to get them in. > Isn't this necessary as well? > > https://git.kernel.org/cgit/linux/kernel/git/andrea/aa.git/commit/?id=0eb943b76537a93fc4dd85cc0cbf937ce8266228 Yes, I think I acked that earlier today. > I can include the below one too, but we need to coordinate to submit > them or eventually some will reject. I think given you already have a series you should pick this up as part of that series. It will need to be reworked slightly anyway to go on top of your series I think. cheers