From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754694AbbIIJzC (ORCPT ); Wed, 9 Sep 2015 05:55:02 -0400 Received: from mail-by2on0105.outbound.protection.outlook.com ([207.46.100.105]:35415 "EHLO na01-by2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751374AbbIIJyw (ORCPT ); Wed, 9 Sep 2015 05:54:52 -0400 Authentication-Results: spf=fail (sender IP is 192.88.158.2) smtp.mailfrom=freescale.com; freescale.mail.onmicrosoft.com; dkim=none (message not signed) header.d=none;freescale.mail.onmicrosoft.com; dmarc=none action=none header.from=freescale.com; From: To: CC: , , , , Tang Yuantian Subject: [PATCH] ahci: qoriq: fixed using uninitialized variable warnings Date: Wed, 9 Sep 2015 17:16:22 +0800 Message-ID: <1441790182-20248-1-git-send-email-Yuantian.Tang@freescale.com> X-Mailer: git-send-email 2.1.0.27.g96db324 X-EOPAttributedMessage: 0 X-Microsoft-Exchange-Diagnostics: 1;BN1BFFO11FD001;1:rYCMnbHbpC5jADLdrh9QJl1XOKkIlESpmwV6sJLqW4cxWuRvsFhJ2GFc6lg7R1nkPDsNW9rlPTBWe+WzrTn4zu750sGG6OtXKCeQWdHiILyfnTch9FlsVhuNxTNSzbMfZlyxWWVXcdlv9y5yjwd0u+zU01orBsg+agYRPFO/ojTfhW8Dnlw4baJ5aSejTWMUFWGiHn3TMTWeZw9jEZZGkv9aIVgJO3HC40FSYDNnWo9endswCVy1ZN8+f0j7BDNgzeKXoGYtB+8wzcX+kjmSoPnHgF6DDsiGhcRZsqYJadoR1GntGHlWlAEhBwOpFtsQfIRuxPsrQCWgmKudVTNAMwPtqz7AHvAB0Rbz78P9tpltqMN/wqAg7U5lUwcWw9t6x4sL8pX1lO5G3s3iRIxdTA== X-Forefront-Antispam-Report: CIP:192.88.158.2;CTRY:US;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(10019020)(6009001)(2980300002)(1110001)(1109001)(339900001)(199003)(189002)(19580395003)(64706001)(110136002)(5001860100001)(36756003)(50226001)(106466001)(5001830100001)(97736004)(48376002)(229853001)(85426001)(81156007)(189998001)(5001960100002)(50466002)(107886002)(47776003)(6806004)(104016003)(86362001)(4001540100001)(46102003)(2351001)(77096005)(19580405001)(68736005)(92566002)(69596002)(77156002)(5003940100001)(105606002)(5007970100001)(62966003)(50986999)(86152002)(87936001)(11100500001)(4001430100001);DIR:OUT;SFP:1102;SCL:1;SRVR:BLUPR03MB568;H:az84smr01.freescale.net;FPR:;SPF:Fail;PTR:InfoDomainNonexistent;A:1;MX:1;LANG:en; MIME-Version: 1.0 Content-Type: text/plain X-Microsoft-Exchange-Diagnostics: 1;BLUPR03MB568;2:HWEqdfyUQVUXKLfnYtd1MAeYrkFBLShh2eqpEpy5v2npxRVpekdYm7zyQxhAEFzbdac2i/AgI0gkuxLqnby9ZDoe4iXxYmhmQIQZsVuJ+wWQrVB/70+E4M4eSwfoO1yLlRnC1a9x6x6ZR1LFXP/QFUUTZ++uiTJBdmhiR4bHyAw=;3:uzNHfHXlAarFswTsAxTmX7Lc9e86Q2avydPucIePs+61OX3+2HM0YyFiqbGr8/zLxwPDy3fkDI+GAacis3IXHKEDh+aMVC6dUI1NBPQrzPO/y2VIAZN3BMw1YTCRfH5aRHRLnsGBr3Qdrmlx92waU4SYSP/OnvILsceEc/SHcK33aE8dEDfCqNWP+MAFAvCYqmMDCtYZy4nUy+XsOdprLcYxum+oTRrRen3APfj2qYI=;25:VgyOUws6OgwRnZDUJsCV0rtf8DnhZoxAqs/j1lhBhNDQXGi7PZolOpyElxzu116iRGBcscFaHulXZJRCixtI+luWKJdX3BAHMvlF2+bNf7oPgNkh9cGbbteeSfD1jZo4UzULV+qwX/ZM8f5GYW/fXDimL3zkhL3tywWh271BvtD5wdHOvOZWq38xzIZ6gt3cZPKwwvL1Q8m/IIS1fB6M0OD3qf8q4TgeqhIu75ovX6+5DsLxrWzzwGeSlvjPcKb5pvrhl3rUFPsE7PQeXbBgKw== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BLUPR03MB568; X-Microsoft-Exchange-Diagnostics: 1;BLUPR03MB568;20:JiMpDrbQktJmrV+F9+bd0sSuSVDtp5gAeF4gMaXaZDX9Xp+oqKhC/ZPiXD19PqSLxopEZJ1S2Kl7xD6gllm6SRe6PgL2er+CnYGXk+PkrrqG707HCrSh1317dr5ub77RbnlUG1iUsQOb3bZQ2K6Zl4Ic8KdPyddUnloqM9Y/fg4k4hrNCFSvHIQiq2tBpvJeq18rsMpt6tdOyzMnqi1IPJ3DjHWEOpOaFzO1QLUSKiNlCkw4ScV84ieHkBpQ0tpK2IzvxdRfWbSiF9VTTd3LiYvTl1T3RqxcPYqGjsdGzhgU6Js9FrU0jnXVV/w7tulWLT4cvB7reOdD/3h02qxZAOYoUKXKbYBQSya4mBE/QQU=;4:4OYtT5yQlxMZvovalMsnHr/DgP51BIO8y8R1WLx40I0R1t3ia7h7xSp25mSBZ8l8LmoCC/EgmphPQO/igifugi+2ihS3LIGxQclvYoZ8swixYwT2Fskp309rPdjlMnWhjnk+YDGDP3n/Tcuu5xU/JgcR7UTJNUWWEf+ZikCNEXG0HcISCQ/HbtCkbvOHMHIO0P015lhwbgthE//D/OQ+/kwIbbGbZSmAjvhv9XOmp4/hGvkw747Hc/apfyw9rimJhwAiUyLEX2qH3uslz5bkdg20VT9CYtpcOnWUUIoRu/Dpf7bmynD55vU7D41xc/k3 X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(5005006)(8121501046)(3002001);SRVR:BLUPR03MB568;BCL:0;PCL:0;RULEID:;SRVR:BLUPR03MB568; X-Forefront-PRVS: 0694C54398 X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;BLUPR03MB568;23:17eaOyMvTK8Q6jbqlzEqtKDdYQMNPZzovJSu1xUFUq?= =?us-ascii?Q?rPuCYPFdPbCGDH0gZL0tksZ3UViucwMGrBkDEUC8wr7f2FyV3QsCs/iGmcQQ?= =?us-ascii?Q?o3eA5NnFs5SpdSbzYAJ/oY7U1wex0xMppdTZqMs2qeg73wtqMzBenI2bklO7?= =?us-ascii?Q?007FOc7QL+zaWne9dheVleeGnvlCFKrmBdl8xaukP+mxrXOym9xy1+e+zJ/h?= =?us-ascii?Q?Tqd3SqkzO0UP+0u+Wx/ryc9kvdRORga6DCnbZ1qTH8dscokidJhnjqnBtLGO?= =?us-ascii?Q?9m6GiiXZF6mxEU9Iio1q9Ga2by6rU0Ld/5dBCgmbeHTmr/HpuGdpci3kWT2H?= =?us-ascii?Q?SOKu7eKWgKqEXwW4jOOSJwWQe8DFZa5S+e/skR4oWkWO1nvTYGqANd9cpRSb?= =?us-ascii?Q?iZ9WBdlNAw55N+Y/rIg6oELKkC6k47ZlWrlM3m1CL7OjMqiSAzQlFYk4oePk?= =?us-ascii?Q?JjxIilcjftFyUMJRk3R0upiRyn+KeXx33Md4TMlc/q1NqqW5eLHffrBlyozH?= =?us-ascii?Q?ZeI8J++jMBFL6egz4YhmUWSp/Tqno0fY9ocmHrMYiWsUyRnUyX3VPwCb1xHc?= =?us-ascii?Q?1Qi86C1WslLMyOukgVOcSKidyrc6l58U/Xd3HNG1n3W2Eg0VvD2Vuhy8m71f?= =?us-ascii?Q?k6pLXNUqkdBUySCCfstpY45SaBwOMgZsTGSonANovHmkVaRn4F2p7rgH0Vhb?= =?us-ascii?Q?ay8AyT4JQOqytShlX7Ah0oOAS4RvzLwq8jwZ0TSfWiDJiKtarBgrMR4FgrxZ?= =?us-ascii?Q?t3xQYLOiF5B//NxgOlmICWHi+5BXmrIH8vQ8Yxfk/A7pren2VUYy2OgYYmHh?= =?us-ascii?Q?uMJKB0G7wHTb8Qfi++UTPOYRP8/a4eJiQXAgv/qPVRLWCgDcKpB3/KPx/Hv3?= =?us-ascii?Q?SO2cZ3kYqGsA5Zei6m0kfY8aVFWswQyvmr40n5XFZVgPQkj2zxxnOW4y7BBk?= =?us-ascii?Q?Vj+bewHeeWVSmHt6Q7SXwRx3QmlQ1DDX6Q/Q4hvt5B78R+ukgWlM55dIjjmi?= =?us-ascii?Q?TSrxqvTAefShkMDdEccc3ExnsGPNCfyQy/DZTDl+WfXNF3tfNUcnL6Pg48af?= =?us-ascii?Q?IzNK9RT5FIr/4/BXbQ72IdVnK0e07uUEFxEK8DZFCzq3pYqqK92esKEvmu/J?= =?us-ascii?Q?EqZd1sOzWUJVrN6LBZIpczukn0GIpYbnkfYTbpoBNK+WBpNhQXob85qa13B9?= =?us-ascii?Q?XFa3t8boRQufH6/H9kl9Jm1RJMdl1faVi9Zhmb4Xmh+vNgBD8QbTSxGA=3D?= =?us-ascii?Q?=3D?= X-Microsoft-Exchange-Diagnostics: 1;BLUPR03MB568;5:TIsJjYuvwQtqPOvzqVzmjOLXdj2+dGJ+7HaW1u6JnHGb46oFz7qYBuE7x4snO8Zj3BthkfcN8AgkpgwYBO0aJ4BbxLV/r7e5IBr+mZYmMRtCQ+BAcMCsMX2JiWvqJgYwi2ZjQUFfsRO9b0geXxqftA==;24:p6/AdSMd4AeF/8IOMhRr50vGtQcFfkuM1dTbyMbCUqn2vt41oiXFNEVDifjrcdmuFqZ3cMi0IdPamT5PycwhLxQtYXVKY8W3Z6rrbkHMkCs=;20:AnqsEtB6rcuo8O+KXMJziStb1JZPZFbIuTycWwPePutlQ8xtYsmU+BpEkQvj9h/a06qH+pf4mJ8BSzT5x+gxxw== X-OriginatorOrg: freescale.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Sep 2015 09:22:11.0262 (UTC) X-MS-Exchange-CrossTenant-Id: 710a03f5-10f6-4d38-9ff4-a80b81da590d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=710a03f5-10f6-4d38-9ff4-a80b81da590d;Ip=[192.88.158.2];Helo=[az84smr01.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR03MB568 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Tang Yuantian kbuild test robot reports the warnings: drivers/ata/ahci_qoriq.c: In function 'ahci_qoriq_hardreset': >> include/asm-generic/io.h:163:2: warning: 'px_is' may be used >> uninitialized in this function [-Wuninitialized] drivers/ata/ahci_qoriq.c:70:14: note: 'px_is' was declared here >> include/asm-generic/io.h:163:2: warning: 'px_cmd' may be used >> uninitialized in this function [-Wuninitialized] drivers/ata/ahci_qoriq.c:70:6: note: 'px_cmd' was declared here This patch fixed it by assigning 0 to px_is and px_cmd variables. This patch also remove line 'struct ccsr_ahci *reg_base' which is not referred by any other codes and thus a dead one. Signed-off-by: Tang Yuantian --- drivers/ata/ahci_qoriq.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/ata/ahci_qoriq.c b/drivers/ata/ahci_qoriq.c index e5e4988..f790852 100644 --- a/drivers/ata/ahci_qoriq.c +++ b/drivers/ata/ahci_qoriq.c @@ -49,7 +49,6 @@ enum ahci_qoriq_type { }; struct ahci_qoriq_priv { - struct ccsr_ahci *reg_base; enum ahci_qoriq_type type; void __iomem *ecc_addr; }; @@ -67,7 +66,7 @@ static int ahci_qoriq_hardreset(struct ata_link *link, unsigned int *class, { const unsigned long *timing = sata_ehc_deb_timing(&link->eh_context); void __iomem *port_mmio = ahci_port_base(link->ap); - u32 px_cmd, px_is, px_val; + u32 px_cmd = 0, px_is = 0, px_val; struct ata_port *ap = link->ap; struct ahci_port_priv *pp = ap->private_data; struct ahci_host_priv *hpriv = ap->host->private_data; -- 2.1.0.27.g96db324