From: LABBE Corentin <clabbe.montjoie@gmail.com>
To: peppe.cavallaro@st.com
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
LABBE Corentin <clabbe.montjoie@gmail.com>
Subject: [PATCH 2/4] stmmac: replace hardcoded function name by __func__
Date: Wed, 9 Sep 2015 15:14:14 +0200 [thread overview]
Message-ID: <1441804456-15914-2-git-send-email-clabbe.montjoie@gmail.com> (raw)
In-Reply-To: <1441804456-15914-1-git-send-email-clabbe.montjoie@gmail.com>
Some printing have the function name hardcoded.
It is better to use __func__ instead.
Signed-off-by: LABBE Corentin <clabbe.montjoie@gmail.com>
---
drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
index cb9efb3..c1dc41b 100644
--- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
+++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
@@ -831,7 +831,7 @@ static int stmmac_init_phy(struct net_device *dev)
snprintf(phy_id_fmt, MII_BUS_ID_SIZE + 3, PHY_ID_FMT, bus_id,
priv->plat->phy_addr);
- dev_dbg(priv->device, "stmmac_init_phy: trying to attach to %s\n",
+ dev_dbg(priv->device, "%s: trying to attach to %s\n", __func__,
phy_id_fmt);
phydev = phy_connect(dev, phy_id_fmt, &stmmac_adjust_link,
@@ -862,8 +862,8 @@ static int stmmac_init_phy(struct net_device *dev)
phy_disconnect(phydev);
return -ENODEV;
}
- dev_dbg(priv->device, "stmmac_init_phy: %s: attached to PHY (UID 0x%x) Link = %d\n",
- dev->name, phydev->phy_id, phydev->link);
+ dev_dbg(priv->device, "%s: %s: attached to PHY (UID 0x%x) Link = %d\n",
+ __func__, dev->name, phydev->phy_id, phydev->link);
priv->phydev = phydev;
--
2.4.6
next prev parent reply other threads:[~2015-09-09 13:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-09 13:14 [PATCH 1/4] stmmac: replace all pr_xxx by their dev_xxx counterpart LABBE Corentin
2015-09-09 13:14 ` LABBE Corentin [this message]
2015-09-09 13:14 ` [PATCH 3/4] stmmac: remove some __func__ printing LABBE Corentin
2015-09-09 13:14 ` [PATCH 4/4] stmmac: Fix simple style problem LABBE Corentin
2015-09-09 16:14 ` [PATCH 1/4] stmmac: replace all pr_xxx by their dev_xxx counterpart Joe Perches
2015-09-10 11:42 ` LABBE Corentin
2015-09-16 7:35 ` LABBE Corentin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1441804456-15914-2-git-send-email-clabbe.montjoie@gmail.com \
--to=clabbe.montjoie@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome