From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753955AbbIIOFJ (ORCPT ); Wed, 9 Sep 2015 10:05:09 -0400 Received: from mailgw01.mediatek.com ([210.61.82.183]:53217 "EHLO mailgw01.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1753045AbbIIOFB (ORCPT ); Wed, 9 Sep 2015 10:05:01 -0400 X-Listener-Flag: 11101 Message-ID: <1441807496.23717.4.camel@mtksdaap41> Subject: Re: [PATCH] soc: mediatek: Move the initial setting of pmic wrap interrupt before requesting irq. From: Henry Chen To: Sascha Hauer CC: Matthias Brugger , , , Date: Wed, 9 Sep 2015 22:04:56 +0800 In-Reply-To: <20150907053920.GW18700@pengutronix.de> References: <1441339512-15510-1-git-send-email-henryc.chen@mediatek.com> <20150907053920.GW18700@pengutronix.de> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.3-0ubuntu6 Content-Transfer-Encoding: 7bit MIME-Version: 1.0 X-MTK: N Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Sascha, On Mon, 2015-09-07 at 07:39 +0200, Sascha Hauer wrote: > On Fri, Sep 04, 2015 at 12:05:12PM +0800, Henry Chen wrote: > > Seperate the initialization of pmic wrap interrupt from pmic wrap init to make sure setting is correct before requesting irq. > > It seems the problem this patch solves is the missing watchdog > initialization when the pwrap is already initialized but the watchdog is > not, so how about a commit log like: > > "The watchdog may not be initialized by the bootloader, even if the rest > of the pwrap is. Move the watchdog initialization out of pwrap_init() > to make sure the watchdog is always initialized and not only when the > pwrap is uninitialized." > > Also please add linebreaks to the commit log. > Yes, thanks for explanation, I will add this on commit log make it more clearly to understand. Henry > > > > Signed-off-by: Henry Chen > > --- > > drivers/soc/mediatek/mtk-pmic-wrap.c | 14 ++++++++++---- > > 1 file changed, 10 insertions(+), 4 deletions(-) > > > > diff --git a/drivers/soc/mediatek/mtk-pmic-wrap.c b/drivers/soc/mediatek/mtk-pmic-wrap.c > > index f432291..c91d629 100644 > > --- a/drivers/soc/mediatek/mtk-pmic-wrap.c > > +++ b/drivers/soc/mediatek/mtk-pmic-wrap.c > > @@ -725,10 +725,6 @@ static int pwrap_init(struct pmic_wrapper *wrp) > > pwrap_writel(wrp, 0x1, PWRAP_WACS2_EN); > > pwrap_writel(wrp, 0x5, PWRAP_STAUPD_PRD); > > pwrap_writel(wrp, 0xff, PWRAP_STAUPD_GRPEN); > > - pwrap_writel(wrp, 0xf, PWRAP_WDT_UNIT); > > - pwrap_writel(wrp, 0xffffffff, PWRAP_WDT_SRC_EN); > > - pwrap_writel(wrp, 0x1, PWRAP_TIMER_EN); > > - pwrap_writel(wrp, ~((1 << 31) | (1 << 1)), PWRAP_INT_EN); > > > > if (pwrap_is_mt8135(wrp)) { > > /* enable pwrap events and pwrap bridge in AP side */ > > @@ -896,6 +892,16 @@ static int pwrap_probe(struct platform_device *pdev) > > return -ENODEV; > > } > > > > + /* > > + * watch dog@pwrap, > > + * The bootloader may not initial the wdt/interrupt setting of pwrap, > > + * set it before reguesting the irq. > > + */ > > /* initialize watchdog, may not be done by the bootloader */ > > Sascha >