From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753178AbbIJEYq (ORCPT ); Thu, 10 Sep 2015 00:24:46 -0400 Received: from smtprelay0015.hostedemail.com ([216.40.44.15]:56646 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750843AbbIJEYo (ORCPT ); Thu, 10 Sep 2015 00:24:44 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::::,RULES_HIT:41:355:379:541:599:960:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1539:1593:1594:1711:1714:1730:1747:1777:1792:2393:2559:2562:2828:3138:3139:3140:3141:3142:3351:3622:3865:3870:3872:4321:5007:6119:6261:7903:10004:10400:10848:11026:11232:11657:11658:11914:12043:12438:12517:12519:12740:13069:13311:13357:21080,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0 X-HE-Tag: bread05_bf262f317f32 X-Filterd-Recvd-Size: 1781 Message-ID: <1441859081.17219.125.camel@perches.com> Subject: Re: [PATCH 6/6] Staging: iio: resolver: Prefer using the BIT macro From: Joe Perches To: Shraddha Barke Cc: Greg Kroah-Hartman , Lars-Peter Clausen , Jonathan Cameron , Peter Meerwald , Hartmut Knaack , linux-kernel@vger.kernel.org, Julia Lawall Date: Wed, 09 Sep 2015 21:24:41 -0700 In-Reply-To: <1441858434-2846-6-git-send-email-shraddha.6596@gmail.com> References: <1441858434-2846-1-git-send-email-shraddha.6596@gmail.com> <1441858434-2846-6-git-send-email-shraddha.6596@gmail.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.12.11-0ubuntu3 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2015-09-10 at 09:43 +0530, Shraddha Barke wrote: > This patch replaces bit shifting on 1 with the BIT(x) macro > as it's extensively used by other function in this driver. [] > diff --git a/drivers/staging/iio/resolver/ad2s1210.c b/drivers/staging/iio/resolver/ad2s1210.c [] > @@ -149,7 +149,7 @@ int ad2s1210_update_frequency_control_word(struct ad2s1210_state *st) > int ret; > unsigned char fcw; > > - fcw = (unsigned char)(st->fexcit * (1 << 15) / st->fclkin); > + fcw = (unsigned char)(st->fexcit * BIT(15) / st->fclkin); Multiplying by a bit isn't very obvious. Maybe just shift it. fcw = (unsigned char)((st->fexcit << 15) / st->fclkin);