From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754019AbbIJHTc (ORCPT ); Thu, 10 Sep 2015 03:19:32 -0400 Received: from mail-bl2on0101.outbound.protection.outlook.com ([65.55.169.101]:30754 "EHLO na01-bl2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752055AbbIJHT0 (ORCPT ); Thu, 10 Sep 2015 03:19:26 -0400 X-Greylist: delayed 21347 seconds by postgrey-1.27 at vger.kernel.org; Thu, 10 Sep 2015 03:19:25 EDT Authentication-Results: spf=fail (sender IP is 192.88.158.2) smtp.mailfrom=freescale.com; freescale.mail.onmicrosoft.com; dkim=none (message not signed) header.d=none;freescale.mail.onmicrosoft.com; dmarc=none action=none header.from=freescale.com; From: To: CC: , , , Tang Yuantian Subject: [PATCH v2] ahci: qoriq: fixed using uninitialized variable warnings Date: Thu, 10 Sep 2015 15:13:32 +0800 Message-ID: <1441869212-14695-1-git-send-email-Yuantian.Tang@freescale.com> X-Mailer: git-send-email 2.1.0.27.g96db324 X-EOPAttributedMessage: 0 X-Microsoft-Exchange-Diagnostics: 1;BL2FFO11OLC008;1:iwiX0p70NuRS3oZx9Uxv2VCwhrQ1LYyHAcT0Li6YHZX0EPSaq5S0nILrHMGDlbe1MiPuZNFXhQa5/8Fnr/Wxk0agcLhOESa5u/Dynh578beGXPfBx9lli3YFg48W2N8dL+p3b4p3yDCICmITkm9h2BNeMZm+567SMb6xlzNYu/eK9H//kE8WpkW4II29U078iYWfSk/ZwmlvARLom0yspdyizHxNg8gy186H2yT1/IoKXvg6xWK4EROyEQxz/zPx3nFag9j0gggVS/PKCTiRT9oMyRTeOoMp3ful5DBFa0RiZs6GIHbmBeUuvbVfMKbIhVdmxB6T62UjJmKxO1MFZwCKdOVAEcTKKyio+xt9pvspvSxKNWsyk/4zU/OWLaXLvcdBCkp14x9LWlKyVlP8xg== X-Forefront-Antispam-Report: CIP:192.88.158.2;CTRY:US;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(10019020)(6009001)(2980300002)(1110001)(1109001)(339900001)(189002)(199003)(4001540100001)(92566002)(68736005)(105606002)(36756003)(107886002)(5007970100001)(85426001)(50466002)(81156007)(50226001)(5003940100001)(87936001)(48376002)(46102003)(229853001)(5001860100001)(64706001)(62966003)(110136002)(2351001)(77156002)(77096005)(189998001)(97736004)(104016003)(19580395003)(5001960100002)(106466001)(5001830100001)(6806004)(11100500001)(86362001)(5001920100001)(69596002)(50986999)(47776003)(86152002)(19580405001)(4001430100001);DIR:OUT;SFP:1102;SCL:1;SRVR:BL2PR03MB561;H:az84smr01.freescale.net;FPR:;SPF:Fail;PTR:InfoDomainNonexistent;MX:1;A:1;LANG:en; MIME-Version: 1.0 Content-Type: text/plain X-Microsoft-Exchange-Diagnostics: 1;BL2PR03MB561;2:6flSDGhSXczxYXHQFyDeNly4/cli3nKRyapBqNv4DVqaCdRmtpgbn/6EpZFyTJGTwFRlmp1Ejt++4xxFFdI425FaCjBQnOrJtrs0jHciGpSgm96th/iBmGD8MeupMX1XE/9UXhefl6fWxhSzvYJEIrULeA/Q0+TFfLmoKT0w6Vc=;3:f3rh181Jwxzq4C28D8qhc2Av2iWTO2Xb9e4ZXIxt9/m9ndaGsEOfOXhwoQtcf0Mf7/bRj73pZ133Z00J2QWKQT1GuP+JGO/ewpMpIo3rLz85lFAc9Ep+Jz0DtAkAMroeSijqYJfWyIwHQN6OyVlkEBX2n5G9MrTD9ySfgc6NGDRdQWnmdX5FrKt2ZXA8rQN5h8QYtNNAf6YdRVP5Ur78WYgoX8dVANJVE+4yB9eQ/tc=;25:2GiofGkomGUhkvu2WzGIRcxbN70VM+2XwSRVRuRb3h8kW91aNJ42CLkeI59yCd/JMCSEGYYo5hGQ6F21E4c68652PJCIFg1VTbmrJqAONcHNkONjYkim/EGSQ743r4nz1j4cFkkcLABLDp2UqCXsiIfxnFOgtMf4iUkUGRJKm2MbabDLlB8JMtzWSrMyOqsdYZkiFDKn7BojjPCwaab2+HlsC0kZ6ZJnTrQ/Wu6bMgM2p/RdVY2tVpltbg4jVimx X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BL2PR03MB561; X-Microsoft-Exchange-Diagnostics: 1;BL2PR03MB561;20:KwPieJW2aCigxRp57m+8eqNx7r6TvdPVa/TtXxHVhiqLRJptTwGn+v2znJxzGfMn3/ybo0RBFpXCiflbwLGWb6IqpEoFGeTg68wrNarPPOBUURlfXzqIGXle5XjbOIQhCejE4PkIQTRtViKPTj8MQHycO+PJHOGzUoVDm8wdUUtGkfr1glwMhnSX/f8jNq5uEfz+nTurdbRzUmEncj5E45b3Mx4w6rll2xHcxRmFUxgfyGkQ6bQrH173092crUqJ3FTNn0raAFQw3AFpUwgNXpXD0IrpwZzMxbDop69bLdGAUBuafKSnebhfhpncyYOxFMvh19hEWrPw4WsXPDcZkNQdiAUvau41mFXG4f/uDFo=;4:jJ0sO4ijPkd3sBAkVmkslabPq5gee4PjyVN//b3bntB58Zn7K3wFmwaoBnIkp5sHsj0U4QFoJv/Hn/MQXz1HwW/hbULik8bDyAW0BFD7urL5+HBN4rX+XQlrcMOmCZJinEC6i//uFbJ9NgKFIN6d3HmPGSIE8T6YfqQU/7znRz+c1rRouncAkEDpotwN1HvFxCuQrla3OZhGsayhxG+faA9VGHBVymlsBQNIt+oWzSmLsm4zxFI3fkuBbpPsG81jXOqDLHLsHcdUClJRIBNCerngNDTmDvOcNdT095hGUMExToewrr9ml9C5TmJSWllr X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(5005006)(8121501046)(3002001);SRVR:BL2PR03MB561;BCL:0;PCL:0;RULEID:;SRVR:BL2PR03MB561; X-Forefront-PRVS: 06952FC175 X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;BL2PR03MB561;23:tySGkxEZ5d6zaJc8ivL23Ae3NJosn544rR7hZvKZfn?= =?us-ascii?Q?BzEjUxaYPsuU4kiBakU+9EHg0s4oSU4vacR4YoRGteYhNNxM8mRQ4a2EZt0p?= =?us-ascii?Q?g0p5qx7F5JJctjk6XYgiwQmBVfI2tpwZSnnA6LcaN2EW5uGcvYvJzx6ixzQh?= =?us-ascii?Q?jvWX/mjeWSPPWSdV+T9uv0hCMNXQ1zndwDGt8HaaIcwlIFMfvOWz8PQwqANm?= =?us-ascii?Q?fRtNG5d6KhXfMfL4/XaiTiZEHEYb3fpA7+j5qbaq8xG4l1w5oXLtIhUhH50O?= =?us-ascii?Q?dxNfMvyOkdB8TXoriyHsyeg8qpW7Qz/aXHUn6SbJNI8asPOvrgmWeqQRCCjz?= =?us-ascii?Q?A25KKv9j9ucYGqc1UMe8+FOnzHDI9p/TDlpVWtQnX5JWRXRV5rNwYsK5g95j?= =?us-ascii?Q?gUKxH54sGB1MK2v+9y+vf24+Bkz7AQsixWS6b/ttbAbn6f0o8Guvsx+eblG1?= =?us-ascii?Q?HMW/SesbKBBBIdIY4xh2Mb670vLx1tyyQsKuBQtVY6MGZuM05ifoaBmwGrd+?= =?us-ascii?Q?euSstdUTK0UWOIv6Kkw3HV9EBY6Cn63ZsipPnnuw6tm51sCWyb2EalFPxcdM?= =?us-ascii?Q?nNndBvbASvEqyPXM6VhW93oy7XberQdfchzr+gom4SLv4dtoAAKkFXjUlnf2?= =?us-ascii?Q?WVBqOgIdQZ/XzfjllwFvWcJ0OVOOaF4xXKOlPb5xZ+HDXxnvKJyXG7vvb2gO?= =?us-ascii?Q?IjMZyzIQdWkIgapZQs86L7A7LMtra3sgSXOiUuXrFHZf5G5FJWqT5pwRWPPV?= =?us-ascii?Q?Hebfc+raZ/ZxtEA8k52QPo0s70EB9vKJ1BwwcTBaIY/P8/kge49acZc7Y23y?= =?us-ascii?Q?U960Qeuxxb53M2xb/9RIvoDTSnDHhVI+ftL4+2DQoRA3q8ah3bl9XW7NXtpW?= =?us-ascii?Q?5rUJBqVCe8LgbvKqUpbHI6worjfJNgMiUisJNlDutvcp6TrGiUZiwOLzr11c?= =?us-ascii?Q?s+uMYtf09YRHFqU0M0neXbCVFY7ulVW9D1UNvuzZ5DfZaTHqXVJS9G6Q32iG?= =?us-ascii?Q?hhPvjppUU7Veydn/KqdEnDQOJKwC5ie+P4KOUcwqWRt1qR8t57EcNM1bOB/6?= =?us-ascii?Q?XErpigMJqotV4AThQtC8q23UWyyMsFs/gvnq0bxsW7i0kJPNPuloKC64D6MU?= =?us-ascii?Q?L14SuMHnufSZaNONak+e7FEYtpLlg5pvtOrE/lQCRwDeQ1xtUzTZzlKlsF3I?= =?us-ascii?Q?yUdnxsEbTPlOQ4MjXAahUV+Gjnx9+bYBKJAm+fKo5OLgEVpY9HfL8d31aM4c?= =?us-ascii?Q?+d/0YxeILlxq6ZpkV65sbRgLWliKqqMyhYRVYl?= X-Microsoft-Exchange-Diagnostics: 1;BL2PR03MB561;5:u4A/XMDcFTMm0BFIk3K/Q4GkJQLkDK/VyjU/OC132LnwETTcHfQNu0Pxx1NE9g8u6VBnEVdIaj2o4aBm6sNJSEUeVI5pAChahrH9bAEQswmo0RKKN5PbApq6kdxGFaAZLdfG7slEUhNlWhVglTWIyg==;24:Ioy7Lgr2nlhrAmPH2vlsQXPBYykxpLWMcpOHRKgwMoWTBlr4TWTh1u1aK6IRUevxqC0/e5VEyqc0Os+KnR065DvYgwsX8n4DUQW4dNPvpos=;20:BihDV4Ch9W8zrdwcNJw6+U4keyGNijXMwhjnhqLDb5W611QWUR2lPBssVDc5607QvNRDhaFK0YylXs1I+FlyiQ== X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Sep 2015 07:19:22.2541 (UTC) X-MS-Exchange-CrossTenant-Id: 710a03f5-10f6-4d38-9ff4-a80b81da590d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=710a03f5-10f6-4d38-9ff4-a80b81da590d;Ip=[192.88.158.2];Helo=[az84smr01.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL2PR03MB561 X-Microsoft-Exchange-Diagnostics: 1;BL2PR03MB386;2:dzdJnIbBdaf+nGPBXaD7avF+eIKPAOY5YB5bG7QBC5nWoDVB+/OuyuI1dU5EXtUfpklOCbBwJgTbA7/kNnRvAwDzSID7bAAVBzNvnEe0e3TqTq6Hs41g7iSQ6zrquVB5mOn8DczD1NwKUbFzn+MEW3ldmdGl1E9c6mg18bChFmI=;23:9FWW97+ed5ICtGnHJ/xWAwOUQ26OsInVPOlv6pvU/P7PzITDAdfVAWcvkfC4WKkw40WKN65EIjODSU+KID+eAzzR7U0oNuid6RAtNKWAw+5TdS50adhUc7jO2mNe3af/NZZgUJ2Hapm81w9gFtdhKjid2G/DD0rGnsXLSMin/TVZdYt/c5BQTaosi54ZMDa0 X-OriginatorOrg: freescale.com Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Tang Yuantian kbuild test robot reports the warnings: drivers/ata/ahci_qoriq.c: In function 'ahci_qoriq_hardreset': >> include/asm-generic/io.h:163:2: warning: 'px_is' may be used >> uninitialized in this function [-Wuninitialized] drivers/ata/ahci_qoriq.c:70:14: note: 'px_is' was declared here >> include/asm-generic/io.h:163:2: warning: 'px_cmd' may be used >> uninitialized in this function [-Wuninitialized] drivers/ata/ahci_qoriq.c:70:6: note: 'px_cmd' was declared here This patch fixed it by making type as a local variable. Signed-off-by: Tang Yuantian --- v2: - try another way to fix the warnings - remove clean up code drivers/ata/ahci_qoriq.c | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/drivers/ata/ahci_qoriq.c b/drivers/ata/ahci_qoriq.c index e5e4988..0d06e76 100644 --- a/drivers/ata/ahci_qoriq.c +++ b/drivers/ata/ahci_qoriq.c @@ -48,9 +48,9 @@ enum ahci_qoriq_type { AHCI_LS2085A, }; +enum ahci_qoriq_type type; struct ahci_qoriq_priv { struct ccsr_ahci *reg_base; - enum ahci_qoriq_type type; void __iomem *ecc_addr; }; @@ -71,7 +71,6 @@ static int ahci_qoriq_hardreset(struct ata_link *link, unsigned int *class, struct ata_port *ap = link->ap; struct ahci_port_priv *pp = ap->private_data; struct ahci_host_priv *hpriv = ap->host->private_data; - struct ahci_qoriq_priv *qoriq_priv = hpriv->plat_data; u8 *d2h_fis = pp->rx_fis + RX_FIS_D2H_REG; struct ata_taskfile tf; bool online; @@ -92,7 +91,7 @@ static int ahci_qoriq_hardreset(struct ata_link *link, unsigned int *class, * After the sequence is complete, software should restore the * PxCMD and PxIS with the stored values. */ - if (qoriq_priv->type == AHCI_LS1021A) { + if (type == AHCI_LS1021A) { px_cmd = readl(port_mmio + PORT_CMD); px_is = readl(port_mmio + PORT_IRQ_STAT); } @@ -106,7 +105,7 @@ static int ahci_qoriq_hardreset(struct ata_link *link, unsigned int *class, ahci_check_ready); /* restore the PxCMD and PxIS on ls1021 */ - if (qoriq_priv->type == AHCI_LS1021A) { + if (type == AHCI_LS1021A) { px_val = readl(port_mmio + PORT_CMD); if (px_val != px_cmd) writel(px_cmd, port_mmio + PORT_CMD); @@ -146,7 +145,7 @@ static int ahci_qoriq_phy_init(struct ahci_host_priv *hpriv) struct ahci_qoriq_priv *qpriv = hpriv->plat_data; void __iomem *reg_base = hpriv->mmio; - switch (qpriv->type) { + switch (type) { case AHCI_LS1021A: writel(SATA_ECC_DISABLE, qpriv->ecc_addr); writel(AHCI_PORT_PHY_1_CFG, reg_base + PORT_PHY1); @@ -188,9 +187,9 @@ static int ahci_qoriq_probe(struct platform_device *pdev) if (!qoriq_priv) return -ENOMEM; - qoriq_priv->type = (enum ahci_qoriq_type)of_id->data; + type = (enum ahci_qoriq_type)of_id->data; - if (qoriq_priv->type == AHCI_LS1021A) { + if (type == AHCI_LS1021A) { res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "sata-ecc"); qoriq_priv->ecc_addr = devm_ioremap_resource(dev, res); -- 2.1.0.27.g96db324