From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752490AbbIJJXT (ORCPT ); Thu, 10 Sep 2015 05:23:19 -0400 Received: from mx1.redhat.com ([209.132.183.28]:46588 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750843AbbIJJXR (ORCPT ); Thu, 10 Sep 2015 05:23:17 -0400 From: Laurent Vivier To: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, "James E.J. Bottomley" Cc: Tyrel Datwyler , dgibson@redhat.com, thuth@redhat.com, pbonzini@redhat.com, lvivier@redhat.com Subject: [PATCH 1/3] ibmvsci: make parameters max_id and max_channel read-only Date: Thu, 10 Sep 2015 11:23:12 +0200 Message-Id: <1441876994-16821-1-git-send-email-lvivier@redhat.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The value of the parameter is never re-read by the driver, so a new value is ignored. Let know the user he can't modify it by removing writable attribute. Signed-off-by: Laurent Vivier --- I resend this patch as James was not cc'ed. drivers/scsi/ibmvscsi/ibmvscsi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/ibmvscsi/ibmvscsi.c b/drivers/scsi/ibmvscsi/ibmvscsi.c index 6a41c36..3e76490 100644 --- a/drivers/scsi/ibmvscsi/ibmvscsi.c +++ b/drivers/scsi/ibmvscsi/ibmvscsi.c @@ -105,9 +105,9 @@ MODULE_AUTHOR("Dave Boutcher"); MODULE_LICENSE("GPL"); MODULE_VERSION(IBMVSCSI_VERSION); -module_param_named(max_id, max_id, int, S_IRUGO | S_IWUSR); +module_param_named(max_id, max_id, int, S_IRUGO); MODULE_PARM_DESC(max_id, "Largest ID value for each channel"); -module_param_named(max_channel, max_channel, int, S_IRUGO | S_IWUSR); +module_param_named(max_channel, max_channel, int, S_IRUGO); MODULE_PARM_DESC(max_channel, "Largest channel value"); module_param_named(init_timeout, init_timeout, int, S_IRUGO | S_IWUSR); MODULE_PARM_DESC(init_timeout, "Initialization timeout in seconds"); -- 2.1.0