From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752709AbbIJJjB (ORCPT ); Thu, 10 Sep 2015 05:39:01 -0400 Received: from metis.ext.pengutronix.de ([92.198.50.35]:51021 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751295AbbIJJi7 (ORCPT ); Thu, 10 Sep 2015 05:38:59 -0400 Message-ID: <1441877934.3280.29.camel@pengutronix.de> Subject: Re: [RESEND PATCH 1/3] arm64: dts: Add reset dts config for Hisilicon Hi6220 SoC From: Philipp Zabel To: Chen Feng Cc: linux-kernel@vger.kernel.org, dan.zhao@hisilicon.com, w.f@huawei.com, haojian.zhuang@linaro.org, bintian.wang@huawei.com, devicetree@vger.kernel.org Date: Thu, 10 Sep 2015 11:38:54 +0200 In-Reply-To: <1441865490-104686-1-git-send-email-puck.chen@hisilicon.com> References: <1441865490-104686-1-git-send-email-puck.chen@hisilicon.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.12.9-1+b1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 2001:67c:670:100:96de:80ff:fec2:9969 X-SA-Exim-Mail-From: p.zabel@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Am Donnerstag, den 10.09.2015, 14:11 +0800 schrieb Chen Feng: > Add reset controller for hi6220 hikey-board. > > Signed-off-by: Chen Feng > --- > arch/arm64/boot/dts/hisilicon/hi6220.dtsi | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/arch/arm64/boot/dts/hisilicon/hi6220.dtsi b/arch/arm64/boot/dts/hisilicon/hi6220.dtsi > index 3f03380..09bb9d1 100644 > --- a/arch/arm64/boot/dts/hisilicon/hi6220.dtsi > +++ b/arch/arm64/boot/dts/hisilicon/hi6220.dtsi > @@ -167,5 +167,12 @@ > clocks = <&ao_ctrl 36>, <&ao_ctrl 36>; > clock-names = "uartclk", "apb_pclk"; > }; > + > + reset_ctrl: reset_ctrl@f7030304 { > + compatible = "hisilicon,hisi_reset_ctl"; Please use hyphens instead of underscores here, also in the next patch you modify the compatible value. I suggest to use compatible = "hisilicon,hi6220-reset-ctl"; here. regards Philipp