From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754537AbbIJQYu (ORCPT ); Thu, 10 Sep 2015 12:24:50 -0400 Received: from smtprelay0062.hostedemail.com ([216.40.44.62]:59670 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754485AbbIJQYs (ORCPT ); Thu, 10 Sep 2015 12:24:48 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::,RULES_HIT:41:355:379:541:599:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2194:2199:2393:2559:2562:2828:2902:3138:3139:3140:3141:3142:3352:3622:3865:3868:3870:3872:4321:4362:5007:6261:7901:7903:10004:10400:10848:11026:11657:11658:11914:12043:12296:12438:12517:12519:12740:13069:13255:13311:13357:21080:21212,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0 X-HE-Tag: noise48_298323ddace30 X-Filterd-Recvd-Size: 2320 Message-ID: <1441902284.17219.165.camel@perches.com> Subject: Re: [PATCH v2 5/5] stmmac: replace if (netif_msg_type) by their netif_xxx counterpart From: Joe Perches To: LABBE Corentin Cc: peppe.cavallaro@st.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Date: Thu, 10 Sep 2015 09:24:44 -0700 In-Reply-To: <1441888653-30535-6-git-send-email-clabbe.montjoie@gmail.com> References: <1441888653-30535-1-git-send-email-clabbe.montjoie@gmail.com> <1441888653-30535-6-git-send-email-clabbe.montjoie@gmail.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.12.11-0ubuntu3 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2015-09-10 at 14:37 +0200, LABBE Corentin wrote: > replace all > if (netif_msg_type(priv)) dev_xxx(priv->devices, ...) > by the simplier macro netif_xxx(priv, hw, priv->dev, ...) Thanks. Trivia: > diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c [] > @@ -733,10 +735,9 @@ static void stmmac_adjust_link(struct net_device *dev) > stmmac_hw_fix_mac_speed(priv); > break; > default: > - if (netif_msg_link(priv)) > - netdev_warn(priv->dev, > - "%s: Speed (%d) not 10/100\n", > - dev->name, phydev->speed); > + netif_warn(priv, link, priv->dev, > + "%s: Speed (%d) not 10/100\n", > + dev->name, phydev->speed); Maybe add another patch removing dev->name where used in logging as it's likely redundant. > @@ -1038,18 +1039,15 @@ static int init_dma_desc_rings(struct net_device *dev, gfp_t flags) > > priv->dma_buf_sz = bfsize; > > - if (netif_msg_probe(priv)) > - netdev_dbg(priv->dev, "%s: txsize %d, rxsize %d, bfsize %d\n", > - __func__, txsize, rxsize, bfsize); > + netif_dbg(priv, probe, priv->dev, "%s: txsize %d, rxsize %d, bfsize %d\n", > + __func__, txsize, rxsize, bfsize); And another removing __func__ from the _dbg uses as it's relatively low value and dynamic debug can add it.