mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Luiz Capitulino <lcapitulino@redhat.com>
To: fweisbec@gmail.com
Cc: linux-kernel@vger.kernel.org, cmetcalf@ezchip.com
Subject: [PATCH 3/3] sched: add_nr_running(): drop tick_nohz_full_cpu() check
Date: Thu, 10 Sep 2015 15:58:27 -0400	[thread overview]
Message-ID: <1441915107-2000-4-git-send-email-lcapitulino@redhat.com> (raw)
In-Reply-To: <1441915107-2000-1-git-send-email-lcapitulino@redhat.com>

tick_nohz_full_kick_cpu() performs the same check.

Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
---
 kernel/sched/sched.h | 20 +++++++++-----------
 1 file changed, 9 insertions(+), 11 deletions(-)

diff --git a/kernel/sched/sched.h b/kernel/sched/sched.h
index 68cda11..102eb18 100644
--- a/kernel/sched/sched.h
+++ b/kernel/sched/sched.h
@@ -1323,17 +1323,15 @@ static inline void add_nr_running(struct rq *rq, unsigned count)
 #endif
 
 #ifdef CONFIG_NO_HZ_FULL
-		if (tick_nohz_full_cpu(rq->cpu)) {
-			/*
-			 * Tick is needed if more than one task runs on a CPU.
-			 * Send the target an IPI to kick it out of nohz mode.
-			 *
-			 * We assume that IPI implies full memory barrier and the
-			 * new value of rq->nr_running is visible on reception
-			 * from the target.
-			 */
-			tick_nohz_full_kick_cpu(rq->cpu);
-		}
+		/*
+		 * Tick is needed if more than one task runs on a CPU.
+		 * Send the target an IPI to kick it out of nohz mode.
+		 *
+		 * We assume that IPI implies full memory barrier and the
+		 * new value of rq->nr_running is visible on reception
+		 * from the target.
+		 */
+		tick_nohz_full_kick_cpu(rq->cpu);
 #endif
 	}
 }
-- 
2.1.0


  parent reply	other threads:[~2015-09-10 19:58 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-10 19:58 [PATCH 0/3] nohz: minor cleanups Luiz Capitulino
2015-09-10 19:58 ` [PATCH 1/3] nohz: mark tick_nohz_full_running as __read_mostly Luiz Capitulino
2015-09-10 19:58 ` [PATCH 2/3] nohz: mark tick_nohz_init_all() as __init Luiz Capitulino
2015-09-24 14:33   ` Frederic Weisbecker
2015-09-10 19:58 ` Luiz Capitulino [this message]
2015-09-24 14:44   ` [PATCH 3/3] sched: add_nr_running(): drop tick_nohz_full_cpu() check Frederic Weisbecker
2015-09-24 14:54     ` Luiz Capitulino

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1441915107-2000-4-git-send-email-lcapitulino@redhat.com \
    --to=lcapitulino@redhat.com \
    --cc=cmetcalf@ezchip.com \
    --cc=fweisbec@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®