From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751513AbbIJWFy (ORCPT ); Thu, 10 Sep 2015 18:05:54 -0400 Received: from mail-bn1bbn0107.outbound.protection.outlook.com ([157.56.111.107]:22085 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751347AbbIJWFw (ORCPT ); Thu, 10 Sep 2015 18:05:52 -0400 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=scottwood@freescale.com; Message-ID: <1441922743.2909.8.camel@freescale.com> Subject: Re: [PATCH v2] powerpc32: memcpy/memset: only use dcbz once cache is enabled From: Scott Wood To: Christophe Leroy CC: Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman , , , Date: Thu, 10 Sep 2015 17:05:43 -0500 In-Reply-To: <20150910064112.7B7791A241C@localhost.localdomain> References: <20150910064112.7B7791A241C@localhost.localdomain> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.16.0-fta1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Originating-IP: [2601:448:8100:f9f:12bf:48ff:fe84:c9a0] X-ClientProxiedBy: DM3PR10CA0016.namprd10.prod.outlook.com (25.164.12.26) To CY1PR03MB1488.namprd03.prod.outlook.com (25.163.17.18) X-Microsoft-Exchange-Diagnostics: 1;CY1PR03MB1488;2:EbsbaM8j8jrXcV32x6y2gCJtuuGSkIQRLGQRmWqhefS8KR8oilTHoXLxRhufIhSowent6dGfisAacwr3NguB7DKRdHqUSn432DW/Kj9Wt5FV64MPHUF46+hvQ8KeU8f9Xpc1XzcQw+j3y4Zu7yeG9a6SnrlOcL3puc40ad/3RUo=;3:IsVyB/rBMJqQDjZqGpOwQNATNhMFQfCRtiAIGwyOyayTVZy+7AYUsTWpEtlKBBEDKMou+wJSu6VpHC47hmOfXy8FQFDJb28J9ymj7QfVu0pit573e2IrATTYU7CcITGZaWEpRdrKWSRXzy6p+Ov1hg==;25:v9LGpYDfxi+DEHd5cD1siM2Zo5+a1BLmxOhBRLb9FABK+ZGp0i64AF7fMjicCqNFc/A2KI9yasQwXDO9mey50q2Ykm7Cw+0ARt2+aoblKf+Mhy/2AiNv1D2JwAojAZZASMt4DILfjjE09NIvWNYPVNgQEjw9o195mc56ThP27Gfg2mx1LsVb0SVNttHJpTi+2JfJHtAqLcYS17pjC36dLMI/SLsNnzxN4/qpy/Y8pAJtVfN8jSsAReB9OsxKynAkVMHPkclymXdSYSR1WBHVMA== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:CY1PR03MB1488; X-Microsoft-Exchange-Diagnostics: 1;CY1PR03MB1488;20:1Gytl71XZXBEszthOHBges8Zlq0uBaFiWSDeYCEd995//3eT9gBR/1WmDZv2JNwcQ5i4VguC37+SwoKKd/mY6bfGFCmeJDrWv/Pq+xgHKL4J98BuRk06WN0qLp2RYyLhIilQIFr+PFxHevDar36OdPGAskfX8/WeOlxhzHqsu6rvp1zBUZQuw7rmhgqeJ8FzfFRAxMyauJOwXa2PB+GLvbVE3qAH2+lg2YQmrRXNeybS9/1v4mBfgaOvX2fUCuWGidir2jKQZpiILQhPwCyVkUNDK7w1elunlwg5Wj8V9igTsGAjANYizpkdV5hJuDhAxsuG35orkqBWO8mUCi9XfsqPrZV9e9eRTDmE2Hj58X+EDaWlEhCd4l00HSw3iqvzejTRaJk7yVssXQ962Y30lLioUa0KSFjDA6mOK90qO+mIEhGcAkdk1nQODnJlr86yPoLbJZkp1H2Aevw6yV6rAKuw9dzPs91Bkc2z1Ar1JGb4lLD3w0yCj4dDqcr1W0ts;4:H5ofv75vD6b/L2RLsNh/hO+HANU4bBKcgjYJNX++6iXlX4d+Y8pZOWTV1AtmEJodsxJy9xLSb/6y0f4i3avD7EoxFSFtoTk0mHyjiu/8LTckGQt9qTSR50XyB17Sxj/EylPYs5Dkha27dsiTD396yBfYjgg4jQsyn66hadCKy9Pew05a0Y7fNW1dbaR2uxe+YSHJpaclOnU5Ya+Gr4fM8wlsfyLYNllFHrtA6+PjITAchXudi4vqbU6nXrVfb/hLbQi9esTD5oO31Ht2IFVuAUj2dk94aRlZpFcgLlJL0oUZ2T0N0la83dUh+9FHRdqv X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(8121501046)(5005006)(3002001);SRVR:CY1PR03MB1488;BCL:0;PCL:0;RULEID:;SRVR:CY1PR03MB1488; X-Forefront-PRVS: 06952FC175 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(6009001)(24454002)(189002)(377424004)(199003)(64706001)(2950100001)(103116003)(86362001)(5001960100002)(23676002)(77156002)(5001830100001)(5007970100001)(97736004)(110136002)(122386002)(68736005)(5001860100001)(189998001)(40100003)(106356001)(42186005)(77096005)(5004730100002)(46102003)(87976001)(101416001)(47776003)(81156007)(33646002)(92566002)(50986999)(105586002)(50226001)(36756003)(5820100001)(62966003)(76176999)(50466002)(4001540100001)(99106002)(3826002)(5001840100002);DIR:OUT;SFP:1102;SCL:1;SRVR:CY1PR03MB1488;H:[IPv6:2601:448:8100:f9f:12bf:48ff:fe84:c9a0];FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtDWTFQUjAzTUIxNDg4OzIzOmYwK3hQRkY0QjEyalRrNlp5VCs0WUdvYUpR?= =?utf-8?B?dkk3aFFCSk5HKzlQSU9SeFE2Nmk5YnRhTS9GK2IvQUlnYTJ2K2F6dGx0dTFF?= =?utf-8?B?T2xDRFc0L3VSR1VpKzRSUlNzVnhvZlZ6ZXBTZVZlRnFjSU5FRlNTNnpqT0lQ?= =?utf-8?B?b3p1QitwcW9rT2Ywb2Vpd3AyUWlYeTlDdDFhOHpXRDdEVTdPc0tjVDVRaHVU?= =?utf-8?B?NmIwdFI2aTZwQ3B1SW1XaVRROTduNWxDODUweXJOY3g3clp6YU1qTmF1NlNX?= =?utf-8?B?NjRyS0Nmby9YZEtDd3RUcnQvT0FFSElHdG14QkpySncwQ1FYTW1hcTIxSjZz?= =?utf-8?B?V1gyL1d4akt1akdPNTRRamtHdnRMcFF6NnBvNDBkNXZhTWh6L0xUazVGaTMw?= =?utf-8?B?cnR4ZWRYYlIwMW1zMDU2aUpjbVZncFVwYng0YnVYMTBEaWZGVzRkR2FaWEFi?= =?utf-8?B?NmFTU2hyVEpvQ2tVVWpOdk9lUjJJbFEzMlFmcWVjNUcrWEpncmZTdExZSEc1?= =?utf-8?B?b2JBRjZITm1aYmVtWjVQbGpSckxralVLZk5xR2FqQVNucUxCYmhCZUpMeVdY?= =?utf-8?B?VGErN1FZdko0K0xVamdSeDdQVDJxaklGUFVLWW5jNmkrZlNrRW1Zc3ZRVkMz?= =?utf-8?B?bC9USWluQ0J2N3k3WlpEZGF5LyszLzFBZmdFZnc5ckZwelFHOS9rRWxQSS9k?= =?utf-8?B?eE9uVTRWNlNiYlpsL0RQL2lnRG1PUEt3WnFNL2ZnNGNHK1BsbTNrRWZVcG1Z?= =?utf-8?B?eERLb1lCTzhCellNb0hBWGhJSi9SbkxGMDNpbFA2blB1b2ZFUUE2Uy9aWmhI?= =?utf-8?B?bnBwMWc4NjR6NFdpVmQ4TDUrUnJGdWpkMHUydTZhaHZZdXhneXRLOVlTMWpB?= =?utf-8?B?ekcvdHF4aHVvR1FTUFM4b2FuSzUvcmRCMFFUVko5QXhOWlJ4Uzgrc3NpTmtE?= =?utf-8?B?L2hqQkd2WkFCdEJzT1VXRTJHbjllUFNibFZOeGtFb3J6TEExTVM4RmVEU0pO?= =?utf-8?B?Qll3cXkxNnFnUUh2U1BaSDlFRU8wUU1CdGpCL1V3SG0xaU5XQnRaeEF1aU1y?= =?utf-8?B?U1dmWlR0ZXJkTDNmNFZmQlU1YjdHelVHQkJubmFWR1dEaWxtVTdBQnRuMEFz?= =?utf-8?B?Q2RXL0F6THVoQWtDeElHRUZHdG9LK3llbnlJR1d3aC9kSnMrMnJpcTNMOHhP?= =?utf-8?B?UG5DNnd1TEtta0JKL2k1cDBpb2hQRlBqdm9GVGJCeDdmZzgvL3lLSVo4QkEx?= =?utf-8?B?RTRDTmlsNUxwZGhhM2N0eDB5VUdVN09PK3JBQm1UT0ZqemhBR1JaZVFTV0tT?= =?utf-8?B?TjVXcldGZHFlaUg4VEgydGphTDZ1eER2M0RzQW5rMEd1YlRwS0gyU09USkFz?= =?utf-8?B?di96VEQvWW5lVllyOXhhTmNXcG5qcFlRS0hNU0xjbXR5NldoQUY5UU1xZFpR?= =?utf-8?B?UnJIN2hUcGRrWUFDdHcrcXhxTXlYYjBlMUJiMW1CZlNlelM0OEFPaEk2YnVO?= =?utf-8?B?czJQcldoemdVVmd1SXdvY2xEenRyNHNpcU1jYUdOS3NCN0UzT3hmU1BXTDNJ?= =?utf-8?Q?HcvojoePHUS6rG/eM1EVAPTYL5DDE+hEfO+2VXjfU1dU=3D?= X-Microsoft-Exchange-Diagnostics: 1;CY1PR03MB1488;5:kFMu3IjdRESw/uNSRGb3Q3e4k/7SVSaB5UJj6zc4jjt+jjDIlOuZXzpejmDqyQ4oN1a6dUG8aQmeJQJWUtnjDhFYNUCcEgSGMtYEejG7aAVzh/WRLP0yGMmV5bqboj/WL+ktj66PPEeI6dxu47ei7w==;24:ze3fpXR9Iq560aZ7NAo44xWr8dtY30z1PyzqJc9oQDvzdH32S3zKvosQYxYrukX4OTKkAH8cth/m+RuIIm5U5E+vQXsYTeRPcpF76yqw3qY=;20:Gt/RajLPG4mtNSF1mINzYEdlJON9iaSNxqM7eSlIXywlANzRmwNYK8A+thsPLFmmiZsIVPPvdS5Xs2x87XMsfQ== SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: freescale.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Sep 2015 22:05:48.9548 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR03MB1488 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2015-09-10 at 08:41 +0200, Christophe Leroy wrote: > > +/* Cache related sections */ > +#define BEGIN_CACHE_SECTION_NESTED(label) START_FTR_SECTION(label) > +#define BEGIN_CACHE_SECTION START_FTR_SECTION(97) > + > +#define END_CACHE_SECTION_NESTED(msk, val, label) \ > + FTR_SECTION_ELSE_NESTED(label) \ > + MAKE_FTR_SECTION_ENTRY(msk, val, label, __cache_fixup) > + > +#define END_CACHE_SECTION(msk, val) \ > + END_CACHE_SECTION_NESTED(msk, val, 97) > + > +#define END_CACHE_SECTION_IFSET(msk) END_CACHE_SECTION((msk), (msk)) > +#define END_CACHE_SECTION_IFCLR(msk) END_CACHE_SECTION((msk), 0) > + > +/* CACHE feature sections with alternatives, use BEGIN_FTR_SECTION to > start */ > +#define CACHE_SECTION_ELSE_NESTED(label) FTR_SECTION_ELSE_NESTED(label) > +#define CACHE_SECTION_ELSE CACHE_SECTION_ELSE_NESTED(97) > +#define ALT_CACHE_SECTION_END_NESTED(msk, val, label) \ > + MAKE_FTR_SECTION_ENTRY(msk, val, label, __cache_fixup) > +#define ALT_CACHE_SECTION_END_NESTED_IFSET(msk, label) \ > + ALT_CACHE_SECTION_END_NESTED(msk, msk, label) > +#define ALT_CACHE_SECTION_END_NESTED_IFCLR(msk, label) \ > + ALT_CACHE_SECTION_END_NESTED(msk, 0, label) > +#define ALT_CACHE_SECTION_END(msk, val) \ > + ALT_CACHE_SECTION_END_NESTED(msk, val, 97) > +#define ALT_CACHE_SECTION_END_IFSET(msk) \ > + ALT_CACHE_SECTION_END_NESTED_IFSET(msk, 97) > +#define ALT_CACHE_SECTION_END_IFCLR(msk) \ > + ALT_CACHE_SECTION_END_NESTED_IFCLR(msk, 97) I don't think this duplication is what Michael meant by "the normal cpu feature sections". What else is going to use this very specific infrastructure? -Scott