mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Peter Ujfalusi <peter.ujfalusi@ti.com>
To: <vinod.koul@intel.com>, <nsekhar@ti.com>, <linux@arm.linux.org.uk>
Cc: <olof@lixom.net>, <arnd@arndb.de>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>, <linux-omap@vger.kernel.org>,
	<dmaengine@vger.kernel.org>
Subject: [PATCH v2 08/23] ARM/dmaengine: edma: Remove limitation on the number of eDMA controllers
Date: Fri, 11 Sep 2015 15:27:07 +0300	[thread overview]
Message-ID: <1441974442-8233-9-git-send-email-peter.ujfalusi@ti.com> (raw)
In-Reply-To: <1441974442-8233-1-git-send-email-peter.ujfalusi@ti.com>

Since the driver stack no longer depends on lookup with id number in a
global array of pointers, the limitation for the number of eDMAs are no
longer needed. We can handle as many eDMAs in legacy and DT boot as we have
memory for them to allocate the needed structures.

Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
---
 arch/arm/common/edma.c | 22 +++++-----------------
 drivers/dma/edma.c     | 17 ++++++++---------
 2 files changed, 13 insertions(+), 26 deletions(-)

diff --git a/arch/arm/common/edma.c b/arch/arm/common/edma.c
index 15b68ce98ec7..0f29997c62df 100644
--- a/arch/arm/common/edma.c
+++ b/arch/arm/common/edma.c
@@ -1227,24 +1227,7 @@ static int edma_probe(struct platform_device *pdev)
 		.parent = &pdev->dev,
 	};
 
-	/* When booting with DT the pdev->id is -1 */
-	if (dev_id < 0)
-		dev_id = arch_num_cc;
-
-	if (dev_id >= EDMA_MAX_CC) {
-		dev_err(dev,
-			"eDMA3 with device id 0 and 1 is supported (id: %d)\n",
-			dev_id);
-		return -EINVAL;
-	}
-
 	if (node) {
-		/* Check if this is a second instance registered */
-		if (arch_num_cc) {
-			dev_err(dev, "only one EDMA instance is supported via DT\n");
-			return -ENODEV;
-		}
-
 		info = edma_setup_info_from_dt(dev, node);
 		if (IS_ERR(info)) {
 			dev_err(dev, "failed to get DT data\n");
@@ -1278,6 +1261,11 @@ static int edma_probe(struct platform_device *pdev)
 
 	cc->dev = dev;
 	cc->id = dev_id;
+	/* When booting with DT the pdev->id is -1 */
+	if (dev_id < 0) {
+		cc->id = 0;
+		dev_id = arch_num_cc;
+	}
 	dev_set_drvdata(dev, cc);
 
 	cc->base = devm_ioremap_resource(dev, mem);
diff --git a/drivers/dma/edma.c b/drivers/dma/edma.c
index 53d48b2a700d..fc91ab9dd1bb 100644
--- a/drivers/dma/edma.c
+++ b/drivers/dma/edma.c
@@ -991,14 +991,12 @@ static void edma_dma_init(struct edma_cc *ecc, struct dma_device *dma,
 	INIT_LIST_HEAD(&dma->channels);
 }
 
-static struct of_dma_filter_info edma_filter_info = {
-	.filter_fn = edma_filter_fn,
-};
-
 static int edma_probe(struct platform_device *pdev)
 {
 	struct edma_cc *ecc;
 	struct device_node *parent_node = pdev->dev.parent->of_node;
+	struct platform_device *parent_pdev =
+					to_platform_device(pdev->dev.parent);
 	int ret;
 
 	ret = dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(32));
@@ -1015,7 +1013,10 @@ static int edma_probe(struct platform_device *pdev)
 	if (!ecc->cc)
 		return -ENODEV;
 
-	ecc->ctlr = pdev->id;
+	ecc->ctlr = parent_pdev->id;
+	if (ecc->ctlr < 0)
+		ecc->ctlr = 0;
+
 	ecc->dummy_slot = edma_alloc_slot(ecc->cc, EDMA_SLOT_ANY);
 	if (ecc->dummy_slot < 0) {
 		dev_err(&pdev->dev, "Can't allocate PaRAM dummy slot\n");
@@ -1038,10 +1039,8 @@ static int edma_probe(struct platform_device *pdev)
 	platform_set_drvdata(pdev, ecc);
 
 	if (parent_node) {
-		dma_cap_set(DMA_SLAVE, edma_filter_info.dma_cap);
-		dma_cap_set(DMA_CYCLIC, edma_filter_info.dma_cap);
-		of_dma_controller_register(parent_node, of_dma_simple_xlate,
-					   &edma_filter_info);
+		of_dma_controller_register(parent_node, of_dma_xlate_by_chan_id,
+					   &ecc->dma_slave);
 	}
 
 	dev_info(&pdev->dev, "TI EDMA DMA engine driver\n");
-- 
2.5.1


  parent reply	other threads:[~2015-09-11 12:33 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-11 12:26 [PATCH v2 00/23] dmaengine/ARM: Merge the edma drivers into one Peter Ujfalusi
2015-09-11 12:27 ` [PATCH v2 01/23] ARM: common: edma: Fix channel parameter for irq callbacks Peter Ujfalusi
2015-09-11 12:27 ` [PATCH v2 02/23] ARM: common: edma: Remove unused functions Peter Ujfalusi
2015-09-11 12:27 ` [PATCH v2 03/23] dmaengine: edma: Simplify and optimize the edma_execute path Peter Ujfalusi
2015-09-11 12:27 ` [PATCH v2 04/23] ARM: davinci/common: Convert edma driver to handle one eDMA instance per driver Peter Ujfalusi
2015-09-18 11:44   ` Peter Ujfalusi
2015-09-11 12:27 ` [PATCH v2 05/23] ARM/dmaengine: edma: Move of_dma_controller_register to the dmaengine driver Peter Ujfalusi
2015-09-11 12:27 ` [PATCH v2 06/23] ARM: common: edma: Internal API to use pointer to 'struct edma' Peter Ujfalusi
2015-09-11 12:27 ` [PATCH v2 07/23] ARM/dmaengine: edma: Public API to use private struct pointer Peter Ujfalusi
2015-09-11 12:27 ` Peter Ujfalusi [this message]
2015-09-11 12:27 ` [PATCH v2 09/23] ARM: davinci: Use platform_device_register_full() to create pdev for eDMA Peter Ujfalusi
2015-09-11 12:27 ` [PATCH v2 10/23] ARM: davinci: Add set dma_mask to eDMA devices Peter Ujfalusi
2015-09-11 12:27 ` [PATCH v2 11/23] ARM/dmaengine: edma: Merge the two drivers under drivers/dmaengine Peter Ujfalusi
2015-09-14 16:12   ` Tony Lindgren
2015-09-15  6:45     ` Peter Ujfalusi
2015-09-11 12:27 ` [PATCH v2 12/23] dmaengine: edma: Allocate memory dynamically for bitmaps and structures Peter Ujfalusi
2015-09-11 12:27 ` [PATCH v2 13/23] dmaengine: edma: Parameter alignment and long line fixes Peter Ujfalusi
2015-09-11 12:27 ` [PATCH v2 14/23] dmaengine: edma: Use devm_kcalloc when possible Peter Ujfalusi
2015-09-11 12:27 ` [PATCH v2 15/23] dmaengine: edma: Cleanup regarding the use of dev around the code Peter Ujfalusi
2015-09-11 12:27 ` [PATCH v2 16/23] dmaengine: edma: Use dev_dbg instead pr_debug Peter Ujfalusi
2015-09-11 12:27 ` [PATCH v2 17/23] dmaengine: edma: Use the edma_write_slot instead open coded memcpy_toio Peter Ujfalusi
2015-09-11 12:27 ` [PATCH v2 18/23] dmaengine: edma: Print warning when linking slots from different eDMA Peter Ujfalusi
2015-09-11 12:27 ` [PATCH v2 19/23] dmaengine: edma: Consolidate the comments for functions Peter Ujfalusi
2015-09-11 12:27 ` [PATCH v2 20/23] dmaengine: edma: Simplify the interrupt handling Peter Ujfalusi
2015-09-11 12:27 ` [PATCH v2 21/23] dmaengine: edma: Move the pending error check into helper function Peter Ujfalusi
2015-09-11 12:27 ` [PATCH v2 22/23] dmaengine: edma: Simplify and optimize ccerr interrupt handler Peter Ujfalusi
2015-09-11 12:27 ` [PATCH v2 23/23] dmaengine: edma: Read channel mapping support only once from HW Peter Ujfalusi
2015-09-12 11:21 ` [PATCH v2 00/23] dmaengine/ARM: Merge the edma drivers into one Sekhar Nori

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1441974442-8233-9-git-send-email-peter.ujfalusi@ti.com \
    --to=peter.ujfalusi@ti.com \
    --cc=arnd@arndb.de \
    --cc=dmaengine@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=nsekhar@ti.com \
    --cc=olof@lixom.net \
    --cc=vinod.koul@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®