From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754304AbbILJIu (ORCPT ); Sat, 12 Sep 2015 05:08:50 -0400 Received: from smtp12.smtpout.orange.fr ([80.12.242.134]:46134 "EHLO smtp.smtpout.orange.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751003AbbILJIs (ORCPT ); Sat, 12 Sep 2015 05:08:48 -0400 X-ME-Helo: belgarion.home X-ME-Date: Sat, 12 Sep 2015 11:08:46 +0200 X-ME-IP: 109.220.179.182 From: Robert Jarzmik To: Ulf Hansson Cc: linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, Robert Jarzmik , Petr Cvek Subject: [PATCH] mmc: pxamci: fix card detect threaded interrupt Date: Sat, 12 Sep 2015 11:03:31 +0200 Message-Id: <1442048611-23314-1-git-send-email-robert.jarzmik@free.fr> X-Mailer: git-send-email 2.1.4 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Change the interrupt flavor of the card detection, from a hard interrupt to a threaded interrupt. There is no strong requirement for a hard interrupt. It fixes the case where the card detection is on a gpio expander, on I2C for example on zylonite board. In this case, the card detect netsted interrupt is called from a threaded interrupt. The request_irq() fails, because a hard irq cannot be a nested interrupt from a threaded interrupt (set __setup_irq()). This was tested on zylonite and mioa701 boards. Signed-off-by: Robert Jarzmik Cc: Petr Cvek --- drivers/mmc/host/pxamci.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/mmc/host/pxamci.c b/drivers/mmc/host/pxamci.c index 1420f29628c7..67c9d1443597 100644 --- a/drivers/mmc/host/pxamci.c +++ b/drivers/mmc/host/pxamci.c @@ -814,8 +814,10 @@ static int pxamci_probe(struct platform_device *pdev) } gpio_direction_input(gpio_cd); - ret = request_irq(gpio_to_irq(gpio_cd), pxamci_detect_irq, - IRQF_TRIGGER_RISING | IRQF_TRIGGER_FALLING, + ret = request_threaded_irq(gpio_to_irq(gpio_cd), NULL, + pxamci_detect_irq, + IRQF_TRIGGER_RISING | IRQF_TRIGGER_FALLING | + IRQF_ONESHOT, "mmc card detect", mmc); if (ret) { dev_err(&pdev->dev, "failed to request card detect IRQ\n"); -- 2.1.4