From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755469AbbIMLOw (ORCPT ); Sun, 13 Sep 2015 07:14:52 -0400 Received: from foss.arm.com ([217.140.101.70]:42644 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752729AbbIMLOt (ORCPT ); Sun, 13 Sep 2015 07:14:49 -0400 From: Marc Zyngier To: Thomas Gleixner , Jason Cooper Cc: Marc Zyngier , Stuart Yoder , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Pavel Fedin Subject: [PATCH 2/3] irqchip/gic-v3-its: Add missing cache flushes Date: Sun, 13 Sep 2015 12:14:32 +0100 Message-Id: <1442142873-20213-3-git-send-email-marc.zyngier@arm.com> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1442142873-20213-1-git-send-email-marc.zyngier@arm.com> References: <1442142873-20213-1-git-send-email-marc.zyngier@arm.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org When the ITS is configured for non-cacheable transactions, make sure that the allocated, zeroed memory is flushed to the Point of Coherency, allowing the ITS to observe the zeros instead of random garbage (or even get its own data overwritten by zeros being evicted from the cache...). This fixes an issue introduced by 241a386c7dbb ("irqchip: gicv3-its: Use non-cacheable accesses when no shareability"). Reported-by: Stuart Yoder Tested-by: Stuart Yoder Signed-off-by: Marc Zyngier --- drivers/irqchip/irq-gic-v3-its.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/irqchip/irq-gic-v3-its.c b/drivers/irqchip/irq-gic-v3-its.c index 26b55c5..ac7ae2b 100644 --- a/drivers/irqchip/irq-gic-v3-its.c +++ b/drivers/irqchip/irq-gic-v3-its.c @@ -898,8 +898,10 @@ retry_baser: * non-cacheable as well. */ shr = tmp & GITS_BASER_SHAREABILITY_MASK; - if (!shr) + if (!shr) { cache = GITS_BASER_nC; + __flush_dcache_area(base, alloc_size); + } goto retry_baser; } @@ -1140,6 +1142,8 @@ static struct its_device *its_create_device(struct its_node *its, u32 dev_id, return NULL; } + __flush_dcache_area(itt, sz); + dev->its = its; dev->itt = itt; dev->nr_ites = nr_ites; -- 2.1.4