mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: <Yuantian.Tang@freescale.com>
To: <hdegoede@redhat.com>
Cc: <tj@kernel.org>, <fengguang.wu@intel.com>,
	<linux-ide@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	Tang Yuantian <Yuantian.Tang@freescale.com>
Subject: [PATCH v3] ahci: qoriq: fixed using uninitialized variable warnings
Date: Mon, 14 Sep 2015 15:12:49 +0800	[thread overview]
Message-ID: <1442214769-46567-1-git-send-email-Yuantian.Tang@freescale.com> (raw)

From: Tang Yuantian <Yuantian.Tang@freescale.com>

kbuild test robot reports the warnings:
drivers/ata/ahci_qoriq.c: In function 'ahci_qoriq_hardreset':
>> include/asm-generic/io.h:163:2: warning: 'px_is' may be used
>> uninitialized in this function [-Wuninitialized]
drivers/ata/ahci_qoriq.c:70:14: note: 'px_is' was declared here
>> include/asm-generic/io.h:163:2: warning: 'px_cmd' may be used
>> uninitialized in this function [-Wuninitialized]
drivers/ata/ahci_qoriq.c:70:6: note: 'px_cmd' was declared here

This is caused by openrisc arch's compiler. This driver is for
QorIQ ARM platforms. So add the dependency on ARM to remove
these warnings.

Signed-off-by: Tang Yuantian <Yuantian.Tang@freescale.com>
---
v3:
	- fix it by in a new way
v2:
	- try another way to fix the warnings
	- remove clean up code

 drivers/ata/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig
index 6aaa3f8..a830344 100644
--- a/drivers/ata/Kconfig
+++ b/drivers/ata/Kconfig
@@ -177,7 +177,7 @@ config AHCI_XGENE
 
 config AHCI_QORIQ
 	tristate "Freescale QorIQ AHCI SATA support"
-	depends on OF
+	depends on OF && ARM
 	help
 	  This option enables support for the Freescale QorIQ AHCI SoC's
 	  onboard AHCI SATA.
-- 
2.1.0.27.g96db324


             reply	other threads:[~2015-09-14  7:18 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-14  7:12 Yuantian.Tang [this message]
2015-09-14  7:21 ` Yuantian Tang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1442214769-46567-1-git-send-email-Yuantian.Tang@freescale.com \
    --to=yuantian.tang@freescale.com \
    --cc=fengguang.wu@intel.com \
    --cc=hdegoede@redhat.com \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®