From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755445AbbINJbu (ORCPT ); Mon, 14 Sep 2015 05:31:50 -0400 Received: from szxga02-in.huawei.com ([119.145.14.65]:54044 "EHLO szxga02-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754205AbbINJbo (ORCPT ); Mon, 14 Sep 2015 05:31:44 -0400 From: Yang Yingliang To: , CC: Yang Yingliang , Jiang Liu , Thomas Gleixner , "Marc Zyngier" , Mark Rutland , "Will Deacon" , Russell King - ARM Linux Subject: [RFC PATCH v2 0/3] arm/arm64: fix a migrating irq bug when hotplug cpu Date: Mon, 14 Sep 2015 17:29:02 +0800 Message-ID: <1442222945-10628-1-git-send-email-yangyingliang@huawei.com> X-Mailer: git-send-email 1.9.5.msysgit.1 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.177.19.219] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi All, There is a bug: When cpu is disabled, all irqs will be migratged to another cpu. In some cases, a new affinity is different, it needed to be coppied to irq's affinity. But if the type of irq is LPI, it's affinity will not be coppied because of irq_set_affinity's return value. As Marc and Will suggested, I refactor the arm/arm64 migrating interrupts code and fix the migrating irq bug while cpu is offline. I'm trying let the core code do the migrating interrupts matter. kernel/irq/migration.c depends on CONFIG_GENERIC_PENDING_IRQ, so I make it selected by CONFIG_SMP and CONFIG_HOTPLUG_CPU and rename it to CONFIG_GENERIC_IRQ_MIGRATION for more general. When CONFIG_GENERIC_IRQ_MIGRATION is enabled, an interrupt whose state_use_accessors is not set with IRQD_MOVE_PCNTXT won't be migrated immediately in irq_set_affinity_locked(). So use irq_set_status_flags() helper to set the state in gic_irq_domain_map(). With the above preparation, move the migrating interrupts code into kernel/irq/migration.c and fix the bug by using irq_do_set_affinity(). Changes in v2: - use the exiting helper to set IRQD_MOVE_PCNTXT flag - use for_each_active_irq() instead of for_each_irq_desc() - add some warn messages when affinity is null or do set affinity failed Cc: Jiang Liu Cc: Thomas Gleixner Cc: Marc Zyngier Cc: Mark Rutland Cc: Will Deacon Cc: Russell King - ARM Linux Yang Yingliang (3): irqchip: GICv3: set non-percpu irqs status with IRQ_MOVE_PCNTXT genirq: rename config GENERIC_PENDING_IRQ to GENERIC_IRQ_MIGRATION arm/arm64: fix a migrating irq bug when hotplug cpu arch/arc/Kconfig | 2 +- arch/arm/Kconfig | 1 + arch/arm/include/asm/irq.h | 1 - arch/arm/kernel/irq.c | 62 --------------------------------------- arch/arm64/Kconfig | 1 + arch/arm64/include/asm/irq.h | 1 - arch/arm64/kernel/irq.c | 62 --------------------------------------- arch/hexagon/Kconfig | 2 +- arch/ia64/Kconfig | 2 +- arch/tile/Kconfig | 2 +- arch/x86/Kconfig | 2 +- arch/x86/kernel/apic/io_apic.c | 2 +- drivers/irqchip/irq-gic-v3.c | 2 ++ include/linux/irq.h | 4 ++- include/linux/irqdesc.h | 2 +- kernel/irq/Kconfig | 4 +-- kernel/irq/Makefile | 2 +- kernel/irq/irqdesc.c | 6 ++-- kernel/irq/manage.c | 2 +- kernel/irq/migration.c | 66 ++++++++++++++++++++++++++++++++++++++++++ kernel/irq/proc.c | 2 +- 21 files changed, 88 insertions(+), 142 deletions(-) -- 2.5.0