From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755548AbbINJcx (ORCPT ); Mon, 14 Sep 2015 05:32:53 -0400 Received: from mail-pa0-f48.google.com ([209.85.220.48]:36654 "EHLO mail-pa0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755483AbbINJc2 (ORCPT ); Mon, 14 Sep 2015 05:32:28 -0400 From: Barry Song <21cnbao@gmail.com> To: broonie@kernel.org, gregkh@linuxfoundation.org, sameo@linux.intel.com, lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, workgroup.linux@csr.com, Guo Zeng , Barry Song Subject: [PATCH 2/3] regmap: irq: add ack_invert flag for chips using cleared bits as ack Date: Mon, 14 Sep 2015 09:40:09 +0000 Message-Id: <1442223610-32257-3-git-send-email-21cnbao@gmail.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1442223610-32257-1-git-send-email-21cnbao@gmail.com> References: <1442223610-32257-1-git-send-email-21cnbao@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Guo Zeng An user will be CSR SiRFSoC ARM chips. Signed-off-by: Guo Zeng Signed-off-by: Barry Song --- drivers/base/regmap/regmap-irq.c | 12 ++++++++++-- include/linux/regmap.h | 2 ++ 2 files changed, 12 insertions(+), 2 deletions(-) diff --git a/drivers/base/regmap/regmap-irq.c b/drivers/base/regmap/regmap-irq.c index 2d21abc..35cd13f 100644 --- a/drivers/base/regmap/regmap-irq.c +++ b/drivers/base/regmap/regmap-irq.c @@ -132,7 +132,11 @@ static void regmap_irq_sync_unlock(struct irq_data *data) if (d->mask_buf[i] && (d->chip->ack_base || d->chip->use_ack)) { reg = d->chip->ack_base + (i * map->reg_stride * d->irq_reg_stride); - ret = regmap_write(map, reg, d->mask_buf[i]); + /* some chips ack by write 0 */ + if (d->chip->ack_invert) + ret = regmap_write(map, reg, ~d->mask_buf[i]); + else + ret = regmap_write(map, reg, d->mask_buf[i]); if (ret != 0) dev_err(d->map->dev, "Failed to ack 0x%x: %d\n", reg, ret); @@ -469,7 +473,11 @@ int regmap_add_irq_chip(struct regmap *map, int irq, int irq_flags, if (d->status_buf[i] && (chip->ack_base || chip->use_ack)) { reg = chip->ack_base + (i * map->reg_stride * d->irq_reg_stride); - ret = regmap_write(map, reg, + if (chip->ack_invert) + ret = regmap_write(map, reg, + ~(d->status_buf[i] & d->mask_buf[i])); + else + ret = regmap_write(map, reg, d->status_buf[i] & d->mask_buf[i]); if (ret != 0) { dev_err(map->dev, "Failed to ack 0x%x: %d\n", diff --git a/include/linux/regmap.h b/include/linux/regmap.h index bb5ba97..313c420 100644 --- a/include/linux/regmap.h +++ b/include/linux/regmap.h @@ -810,6 +810,7 @@ struct regmap_irq { * @mask_invert: Inverted mask register: cleared bits are masked out. * @unmask_separate: unmask is separate register from mask. * @use_ack: Use @ack register even if it is zero. + * @ack_invert: Inverted ack register: cleared bits for ack. * @wake_invert: Inverted wake register: cleared bits are wake enabled. * @runtime_pm: Hold a runtime PM lock on the device when accessing it. * @@ -831,6 +832,7 @@ struct regmap_irq_chip { bool mask_invert:1; bool unmask_separate:1; bool use_ack:1; + bool ack_invert:1; bool wake_invert:1; bool runtime_pm:1; -- 1.9.1