From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752746AbbIOCKu (ORCPT ); Mon, 14 Sep 2015 22:10:50 -0400 Received: from shadbolt.e.decadent.org.uk ([88.96.1.126]:55563 "EHLO shadbolt.e.decadent.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751708AbbIOCKs convert rfc822-to-8bit (ORCPT ); Mon, 14 Sep 2015 22:10:48 -0400 Message-ID: <1442283045.29883.1.camel@decadent.org.uk> Subject: Re: [PATCH 2.6.32 18/62] s390/hibernate: fix save and restore of kernel text section From: Ben Hutchings To: Willy Tarreau Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, Heiko Carstens , Martin Schwidefsky Date: Tue, 15 Sep 2015 03:10:45 +0100 In-Reply-To: <20150912225607.341984869@1wt.eu> References: <20150912225607.341984869@1wt.eu> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT X-Mailer: Evolution 3.12.9-1+b1 Mime-Version: 1.0 X-SA-Exim-Connect-IP: 192.168.2.6 X-SA-Exim-Mail-From: ben@decadent.org.uk X-SA-Exim-Scanned: No (on shadbolt.decadent.org.uk); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 2015-09-13 at 00:56 +0200, Willy Tarreau wrote: > 2.6.32-longterm review patch. If anyone has any objections, please let me know. > > ------------------ > > From: Heiko Carstens > > commit d74419495633493c9cd3f2bbeb7f3529d0edded6 upstream. > > Sebastian reported a crash caused by a jump label mismatch after resume. > This happens because we do not save the kernel text section during suspend > and therefore also do not restore it during resume, but use the kernel image > that restores the old system. [...] I don't think this is needed because jump labels aren't implemented in 2.6.32. But maybe there was some other mechanism that changes the kernel text on s390? Ben.