From: Jason Wang <jasowang@redhat.com>
To: gleb@kernel.org, pbonzini@redhat.com, kvm@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: mst@redhat.com, cornelia.huck@de.ibm.com,
Jason Wang <jasowang@redhat.com>
Subject: [PATCH V6 0/6] Fast mmio eventfd fixes
Date: Tue, 15 Sep 2015 14:41:53 +0800 [thread overview]
Message-ID: <1442299319-5253-1-git-send-email-jasowang@redhat.com> (raw)
Hi:
This series fixes two issues of fast mmio eventfd:
1) A single iodev instance were registerd on two buses: KVM_MMIO_BUS
and KVM_FAST_MMIO_BUS. This will cause double in
ioeventfd_destructor()
2) A zero length iodev on KVM_MMIO_BUS will never be found but
kvm_io_bus_cmp(). This will lead e.g the eventfd will be trapped by
qemu instead of host.
1 is fixed by allocating two instances of iodev and introduce a new
capability for userspace. 2 is fixed by ignore the actual length if
the length of iodev is zero in kvm_io_bus_cmp().
Please review.
Changes from V5:
- move patch of explicitly checking for KVM_MMIO_BUS to patch 1 and
remove the unnecessary checks
- even more grammar and typo fixes
- rabase to kvm.git
- document KVM_CAP_FAST_MMIO
Changes from V4:
- move the location of kvm_assign_ioeventfd() in patch 1 which reduce
the change set.
- commit log typo fixes
- switch to use kvm_deassign_ioeventfd_id) when fail to register to
fast mmio bus
- change kvm_io_bus_cmp() as Paolo's suggestions
- introduce a new capability to avoid new userspace crash old kernel
- add a new patch that only try to register mmio eventfd on fast mmio
bus
Changes from V3:
- Don't do search on two buses when trying to do write on
KVM_MMIO_BUS. This fixes a small regression found by vmexit.flat.
- Since we don't do search on two buses, change kvm_io_bus_cmp() to
let it can find zero length iodevs.
- Fix the unnecessary lines in tracepoint patch.
Changes from V2:
- Tweak styles and comment suggested by Cornelia.
Changes from v1:
- change ioeventfd_bus_from_flags() to return KVM_FAST_MMIO_BUS when
needed to save lots of unnecessary changes.
Jason Wang (6):
kvm: don't try to register to KVM_FAST_MMIO_BUS for non mmio eventfd
kvm: factor out core eventfd assign/deassign logic
kvm: fix double free for fast mmio eventfd
kvm: fix zero length mmio searching
kvm: add tracepoint for fast mmio
kvm: add fast mmio capabilitiy
Documentation/virtual/kvm/api.txt | 7 ++-
arch/x86/kvm/trace.h | 18 ++++++
arch/x86/kvm/vmx.c | 1 +
arch/x86/kvm/x86.c | 1 +
include/uapi/linux/kvm.h | 1 +
virt/kvm/eventfd.c | 124 ++++++++++++++++++++++----------------
virt/kvm/kvm_main.c | 20 +++++-
7 files changed, 118 insertions(+), 54 deletions(-)
--
2.1.4
next reply other threads:[~2015-09-15 6:42 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-15 6:41 Jason Wang [this message]
2015-09-15 6:41 ` [PATCH V6 1/6] kvm: don't try to register to KVM_FAST_MMIO_BUS for non mmio eventfd Jason Wang
2015-09-15 7:05 ` Cornelia Huck
2015-09-15 6:41 ` [PATCH V6 2/6] kvm: factor out core eventfd assign/deassign logic Jason Wang
2015-09-15 7:07 ` Cornelia Huck
2015-09-15 6:41 ` [PATCH V6 3/6] kvm: fix double free for fast mmio eventfd Jason Wang
2015-09-15 7:13 ` Cornelia Huck
2015-09-15 6:41 ` [PATCH V6 4/6] kvm: fix zero length mmio searching Jason Wang
2015-09-15 7:52 ` Cornelia Huck
2015-09-15 6:41 ` [PATCH V6 5/6] kvm: add tracepoint for fast mmio Jason Wang
2015-09-15 6:41 ` [PATCH V6 6/6] kvm: add fast mmio capabilitiy Jason Wang
2015-09-15 15:07 ` Paolo Bonzini
2015-09-15 16:13 ` Cornelia Huck
2015-09-15 16:29 ` Paolo Bonzini
2015-09-15 16:44 ` Cornelia Huck
2015-09-15 16:47 ` Paolo Bonzini
2015-09-15 15:08 ` [PATCH V6 0/6] Fast mmio eventfd fixes Paolo Bonzini
2015-09-15 19:26 ` Michael S. Tsirkin
2015-09-16 8:11 ` Paolo Bonzini
2015-11-08 17:11 ` Michael S. Tsirkin
2015-11-09 4:35 ` Jason Wang
2015-11-09 20:19 ` Michael S. Tsirkin
2015-11-10 6:25 ` Jason Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1442299319-5253-1-git-send-email-jasowang@redhat.com \
--to=jasowang@redhat.com \
--cc=cornelia.huck@de.ibm.com \
--cc=gleb@kernel.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®