From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932223AbbIOJM7 (ORCPT ); Tue, 15 Sep 2015 05:12:59 -0400 Received: from mail.kernel.org ([198.145.29.136]:53875 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755022AbbIOJMz (ORCPT ); Tue, 15 Sep 2015 05:12:55 -0400 From: lizf@kernel.org To: stable@vger.kernel.org Cc: linux-kernel@vger.kernel.org, "David S. Miller" , Zefan Li Subject: [PATCH 3.4 135/146] ipv4: Missing sk_nulls_node_init() in ping_unhash(). Date: Tue, 15 Sep 2015 17:04:10 +0800 Message-Id: <1442307861-32031-135-git-send-email-lizf@kernel.org> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1442307787-31952-1-git-send-email-lizf@kernel.org> References: <1442307787-31952-1-git-send-email-lizf@kernel.org> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: "David S. Miller" 3.4.109-rc1 review patch. If anyone has any objections, please let me know. ------------------ commit a134f083e79fb4c3d0a925691e732c56911b4326 upstream. If we don't do that, then the poison value is left in the ->pprev backlink. This can cause crashes if we do a disconnect, followed by a connect(). Tested-by: Linus Torvalds Reported-by: Wen Xu Signed-off-by: David S. Miller Signed-off-by: Zefan Li --- net/ipv4/ping.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/ipv4/ping.c b/net/ipv4/ping.c index cb90852..9f471c3 100644 --- a/net/ipv4/ping.c +++ b/net/ipv4/ping.c @@ -138,6 +138,7 @@ static void ping_v4_unhash(struct sock *sk) if (sk_hashed(sk)) { write_lock_bh(&ping_table.lock); hlist_nulls_del(&sk->sk_nulls_node); + sk_nulls_node_init(&sk->sk_nulls_node); sock_put(sk); isk->inet_num = 0; isk->inet_sport = 0; -- 1.9.1