From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751895AbbIOK24 (ORCPT ); Tue, 15 Sep 2015 06:28:56 -0400 Received: from mga02.intel.com ([134.134.136.20]:34801 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751518AbbIOK2z (ORCPT ); Tue, 15 Sep 2015 06:28:55 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.17,535,1437462000"; d="scan'208";a="769333223" From: "Kirill A. Shutemov" To: Andrew Morton , Hugh Dickins Cc: Andrea Arcangeli , Dave Hansen , Vlastimil Babka , Johannes Weiner , Michal Hocko , David Rientjes , "Aneesh Kumar K.V" , linux-kernel@vger.kernel.org, linux-mm@kvack.org, "Kirill A. Shutemov" Subject: [PATCHv6 0/7] Fix compound_head() race Date: Tue, 15 Sep 2015 13:28:08 +0300 Message-Id: <1442312895-124384-1-git-send-email-kirill.shutemov@linux.intel.com> X-Mailer: git-send-email 2.5.1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Here's my attempt on fixing race in compound_head(). It should make compound_head() reliable in all contexts. The last patch is optional. It applies cleanly into mmotm patchstack just before my page-flags patchset. As expected, it causes few conflicts with patches: page-flags-introduce-page-flags-policies-wrt-compound-pages.patch mm-sanitize-page-mapping-for-tail-pages.patch include-linux-page-flagsh-rename-macros-to-avoid-collisions.patch Updated patches with solved conflicts can be found here: http://marc.info/?l=linux-kernel&m=144007388303804&q=p4 http://marc.info/?l=linux-kernel&m=144007388303804&q=p5 http://marc.info/?l=linux-kernel&m=144007388303804&q=p3 v6: - cosmetic-only changes based on feedback form Vlastimil Babka and Alexander Duyck; - More Ackes/Reviewed-by; v5: - Fix collision with hugetlb_cgroup (see updated patch description in patch 5/7); v4: - init page->lru on init_reserved_page() for DEFERRED_STRUCT_PAGE_INIT=n; - fix zsmalloc breakage (repored by Sergey Senozhatsky); - move #ifdef CONFIG_64BIT into separate patch; - enum compound_dtor_id; - move pmd_huge_pte to other word to avoid conflict with compound_head; - compile-time LIST_POISON1 sanity check; - few cleanups around page->rcu_head; v3: - Fix build without hugetlb; - Drop page->first_page; - Update comment for free_compound_page(); - Use 'unsigned int' for page order; v2: Per Hugh's suggestion page->compound_head is moved into third double word. This way we can avoid memory overhead which v1 had in some cases. This place in struct page is rather overloaded. More testing is required to make sure we don't collide with anyone. Kirill A. Shutemov (7): mm: drop page->slab_page slab, slub: use page->rcu_head instead of page->lru plus cast zsmalloc: use page->private instead of page->first_page mm: pack compound_dtor and compound_order into one word in struct page mm: make compound_head() robust mm: use 'unsigned int' for page order mm: use 'unsigned int' for compound_dtor/compound_order on 64BIT Documentation/vm/split_page_table_lock | 4 +- arch/xtensa/configs/iss_defconfig | 1 - include/linux/hugetlb_cgroup.h | 4 +- include/linux/mm.h | 82 ++++++++++----------------------- include/linux/mm_types.h | 40 ++++++++++++---- include/linux/page-flags.h | 80 ++++++++------------------------ mm/Kconfig | 12 ----- mm/debug.c | 5 -- mm/huge_memory.c | 3 +- mm/hugetlb.c | 35 +++++++------- mm/hugetlb_cgroup.c | 2 +- mm/internal.h | 8 ++-- mm/memory-failure.c | 7 --- mm/page_alloc.c | 84 ++++++++++++++++++++++------------ mm/slab.c | 17 ++----- mm/slub.c | 5 +- mm/swap.c | 4 +- mm/zsmalloc.c | 11 ++--- 18 files changed, 165 insertions(+), 239 deletions(-) -- 2.5.1