From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752074AbbIOK5E (ORCPT ); Tue, 15 Sep 2015 06:57:04 -0400 Received: from mail-wi0-f174.google.com ([209.85.212.174]:35837 "EHLO mail-wi0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751005AbbIOK5D (ORCPT ); Tue, 15 Sep 2015 06:57:03 -0400 From: Leo Yan To: Ingo Molnar , Peter Zijlstra , linux-kernel@vger.kernel.org Cc: Leo Yan Subject: [PATCH] sched/fair: Remove unnecessary parameter for group_classify Date: Tue, 15 Sep 2015 18:56:45 +0800 Message-Id: <1442314605-14838-1-git-send-email-leo.yan@linaro.org> X-Mailer: git-send-email 1.9.1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Function group_classify() has not used parameter "env", so remove it. And unify code to always use group_classify() to calculate group's load type. Signed-off-by: Leo Yan --- kernel/sched/fair.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index b716e23..66a6c12 100644 --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c @@ -6229,9 +6229,9 @@ group_is_overloaded(struct lb_env *env, struct sg_lb_stats *sgs) return false; } -static enum group_type group_classify(struct lb_env *env, - struct sched_group *group, - struct sg_lb_stats *sgs) +static inline enum +group_type group_classify(struct sched_group *group, + struct sg_lb_stats *sgs) { if (sgs->group_no_capacity) return group_overloaded; @@ -6296,7 +6296,7 @@ static inline void update_sg_lb_stats(struct lb_env *env, sgs->group_weight = group->group_weight; sgs->group_no_capacity = group_is_overloaded(env, sgs); - sgs->group_type = group_classify(env, group, sgs); + sgs->group_type = group_classify(group, sgs); } /** @@ -6430,7 +6430,7 @@ static inline void update_sd_lb_stats(struct lb_env *env, struct sd_lb_stats *sd group_has_capacity(env, &sds->local_stat) && (sgs->sum_nr_running > 1)) { sgs->group_no_capacity = 1; - sgs->group_type = group_overloaded; + sgs->group_type = group_classify(sg, sgs); } if (update_sd_pick_busiest(env, sds, sg, sgs)) { -- 1.9.1