From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751979AbbIOLwi (ORCPT ); Tue, 15 Sep 2015 07:52:38 -0400 Received: from mail-pa0-f48.google.com ([209.85.220.48]:32818 "EHLO mail-pa0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751558AbbIOLwh (ORCPT ); Tue, 15 Sep 2015 07:52:37 -0400 From: Sudip Mukherjee To: Greg Kroah-Hartman Cc: linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org, Sudip Mukherjee Subject: [PATCH] staging: rtl8192e: fix memory leak Date: Tue, 15 Sep 2015 17:22:28 +0530 Message-Id: <1442317948-21868-1-git-send-email-sudipm.mukherjee@gmail.com> X-Mailer: git-send-email 1.9.1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org If the size of the firmware is not as expected then we are jumping to the error path but we missed releasing the firmware. Signed-off-by: Sudip Mukherjee --- drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c b/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c index 5c527c4..3c1b86c 100644 --- a/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c +++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c @@ -273,6 +273,7 @@ bool rtl92e_init_fw(struct net_device *dev) sizeof(pfirmware->firmware_buf[i])) { RT_TRACE(COMP_FIRMWARE, "img file size exceed the container struct buffer fail!\n"); + release_firmware(fw_entry); goto download_firmware_fail; } -- 1.9.1