From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753347AbbIOOms (ORCPT ); Tue, 15 Sep 2015 10:42:48 -0400 Received: from mailout4.samsung.com ([203.254.224.34]:42165 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753728AbbIOO11 (ORCPT ); Tue, 15 Sep 2015 10:27:27 -0400 X-AuditID: cbfee61a-f79a06d000005c6f-7b-55f82acd1b15 From: Robert Baldyga To: balbi@ti.com Cc: gregkh@linuxfoundation.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, b.zolnierkie@samsung.com, m.szyprowski@samsung.com, andrzej.p@samsung.com, Robert Baldyga Subject: [PATCH 01/26] usb: gadget: fix few outdated comments Date: Tue, 15 Sep 2015 16:26:44 +0200 Message-id: <1442327229-28320-2-git-send-email-r.baldyga@samsung.com> X-Mailer: git-send-email 1.9.1 In-reply-to: <1442327229-28320-1-git-send-email-r.baldyga@samsung.com> References: <1442327229-28320-1-git-send-email-r.baldyga@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprOLMWRmVeSWpSXmKPExsVy+t9jAd2zWj9CDa5t07SY9bKdxWLjjPWs Fgfv11s0L17PZnF51xw2i0XLWpkt1h65y27x4PBOdgcOj/1z17B79G1Zxehx/MZ2Jo/Pm+QC WKK4bFJSczLLUov07RK4Mr59v8ZecF204uePj8wNjFcFuxg5OSQETCS+dG9khLDFJC7cW8/W xcjFISSwlFFizu33UM5PRomNU7tZQarYBHQktnyfANYhIiAgsf7FJXaQImaBC4wS7xesYwdJ CAvYSvQ2NTCB2CwCqhL/r19gBrF5BVwlel6eZYZYJydx8thksKGcAm4S+5edBIsLAdWcOniX fQIj7wJGhlWMEqkFyQXFSem5hnmp5XrFibnFpXnpesn5uZsYwcH1TGoH48Fd7ocYBTgYlXh4 I9q/hwqxJpYVV+YeYpTgYFYS4ZXl+BEqxJuSWFmVWpQfX1Sak1p8iFGag0VJnFd25bNQIYH0 xJLU7NTUgtQimCwTB6dUA6Oli365EMO6L5Hq3+e9ck5hNNFYOKmntumFI4Pnnqf5PrPixDZu ml5araRr4Fmdt3i7ouuiZY3GN5fuq5aMZjnp1Nz9b7n2zfyQtxmxBidXrJjEsn3Kkuzbe/pt nGa/drKac8H21zV2oUtr4j6lGTgtnWLfM+VnXQ/zqww3L50Dk3MsU1pCLZRYijMSDbWYi4oT AV/ON/gqAgAA Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fix comments in code to make them up to date. composite: claiming endpoint is now done by setting ep->claimed flag, not ep->driver_data. epautoconf: usb_ep_autoconfig() and usb_ep_autoconfig_ss() return claimed endpoint with ep->claimed flag already set. Signed-off-by: Robert Baldyga --- drivers/usb/gadget/composite.c | 4 +--- drivers/usb/gadget/epautoconf.c | 8 ++++---- 2 files changed, 5 insertions(+), 7 deletions(-) diff --git a/drivers/usb/gadget/composite.c b/drivers/usb/gadget/composite.c index b474499..3e95c0e 100644 --- a/drivers/usb/gadget/composite.c +++ b/drivers/usb/gadget/composite.c @@ -839,9 +839,7 @@ int usb_add_config(struct usb_composite_dev *cdev, } } - /* set_alt(), or next bind(), sets up - * ep->driver_data as needed. - */ + /* set_alt(), or next bind(), sets up ep->claimed as needed */ usb_ep_autoconfig_reset(cdev->gadget); done: diff --git a/drivers/usb/gadget/epautoconf.c b/drivers/usb/gadget/epautoconf.c index 6399c10..0f4ece4 100644 --- a/drivers/usb/gadget/epautoconf.c +++ b/drivers/usb/gadget/epautoconf.c @@ -53,13 +53,13 @@ * the restrictions that may apply. Some combinations of driver * and hardware won't be able to autoconfigure. * - * On success, this returns an un-claimed usb_ep, and modifies the endpoint + * On success, this returns an claimed usb_ep, and modifies the endpoint * descriptor bEndpointAddress. For bulk endpoints, the wMaxPacket value * is initialized as if the endpoint were used at full speed and * the bmAttribute field in the ep companion descriptor is * updated with the assigned number of streams if it is * different from the original value. To prevent the endpoint - * from being returned by a later autoconfig call, claim it by + * from being returned by a later autoconfig call, claims it by * assigning ep->claimed to true. * * On failure, this returns a null endpoint descriptor. @@ -154,10 +154,10 @@ EXPORT_SYMBOL_GPL(usb_ep_autoconfig_ss); * USB controller, and it can't know all the restrictions that may apply. * Some combinations of driver and hardware won't be able to autoconfigure. * - * On success, this returns an un-claimed usb_ep, and modifies the endpoint + * On success, this returns an claimed usb_ep, and modifies the endpoint * descriptor bEndpointAddress. For bulk endpoints, the wMaxPacket value * is initialized as if the endpoint were used at full speed. To prevent - * the endpoint from being returned by a later autoconfig call, claim it + * the endpoint from being returned by a later autoconfig call, claims it * by assigning ep->claimed to true. * * On failure, this returns a null endpoint descriptor. -- 1.9.1